Bug 209240 – [Web Animations] Mark promises as handled when rejected

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

We need to implement https://github.com/w3c/csswg-drafts/issues/4556. This will help with test flakiness so that we don't get console messages when calling cancel().

[Radar WebKit Bug Importer]

<rdar://problem/60592305>

[Antoine Quint]

Created attachment 393958 [details]
Patch

[youenn fablet]

Comment on attachment 393958 [details]
Patch

Looks ok to me.

I still think we should not be passing a Handled value to reject() in this case though.
This promise is an attribute or state promise, reject should always be using Handled.
Instead of leaving the choice here, I would hardcode RejectAsHandled::Yes in DOMPromiseProxyWithResolveCallback<IDLType>::reject, something like:
inline void DOMPromiseProxyWithResolveCallback<IDLType>::reject(Exception exception)
{
    ASSERT(!m_valueOrException);

    m_valueOrException = ExceptionOr<void> { WTFMove(exception) };
    for (auto& deferredPromise : m_deferredPromises)
        deferredPromise->reject(m_valueOrException->exception(), RejectAsHandled::Yes);
}

[Antoine Quint]

(In reply to youenn fablet from comment #3)
> Comment on attachment 393958 [details]
> Patch
> 
> Looks ok to me.
> 
> I still think we should not be passing a Handled value to reject() in this
> case though.
> This promise is an attribute or state promise, reject should always be using
> Handled.
> Instead of leaving the choice here, I would hardcode RejectAsHandled::Yes in
> DOMPromiseProxyWithResolveCallback<IDLType>::reject, something like:
> inline void DOMPromiseProxyWithResolveCallback<IDLType>::reject(Exception
> exception)
> {
>     ASSERT(!m_valueOrException);
> 
>     m_valueOrException = ExceptionOr<void> { WTFMove(exception) };
>     for (auto& deferredPromise : m_deferredPromises)
>         deferredPromise->reject(m_valueOrException->exception(),
> RejectAsHandled::Yes);
> }

I'm landing this patch as-is, I don't feel like we should make that kind of broader change without some standards discussion first.

[EWS]

Committed r258702: <https://trac.webkit.org/changeset/258702>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393958 [details].