Bug 209229 – [GTK][WPE] Flatpak error when running run-webkit-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sergio Villar Senin]

I get the following error when trying to run the tests in a directory where all the tests are skipped:

Command '['flatpak', 'build', '--die-with-parent', '--talk-name=org.a11y.Bus', '--talk-name=org.gtk.vfs', '--talk-name=org.gtk.vfs.*', '--bind-mount=/run/shm=/dev/shm', '--bind-mount=/run/host//tmp=/tmp', '--bind-mount=/app/webkit=/home/sergio/checkout/WPE', '--bind-mount=/app/webkit/WebKitBuild/Release=/home/sergio/checkout/WPE/WebKitBuild/WPE/Release', '--device=all', '--device=dri', '--filesystem=host', '--share=ipc', '--share=network', '--socket=pulseaudio', '--socket=system-bus', '--socket=wayland', '--socket=x11', '--system-talk-name=org.a11y.Bus', '--system-talk-name=org.freedesktop.GeoClue2', '--talk-name=org.a11y.Bus', '--talk-name=org.freedesktop.Flatpak', '--env=LANG=en_US.UTF-8', '--env=TZ=PST8PDT', '--env=GTK_MODULES=gail:atk-bridge', '--env=WAYLAND_DISPLAY=wayland-0', '--env=DISPLAY=:0', '--env=WEBKIT_TOP_LEVEL=/app/', '--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so', '/home/sergio/checkout/WPE/WebKitBuild/UserFlatpak', '/app/webkit/Tools/Scripts/run-webkit-tests', '--wpe', 'LayoutTests/imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https.html']' returned non-zero exit status 255

[Philippe Normand]

Actually I can't reproduce this issue:

run-webkit-tests --gtk --verbose imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https.html
webkitpy.common.system.logutils: [DEBUG] Debug logging enabled.
flatpakutils: [DEBUG] Using flatpak user dir: /home/phil/WebKit/WebKitBuild/UserFlatpak
webkitpy.port.win: [DEBUG] Not running on native Windows.
webkitpy.common.system.executive: [DEBUG] "perl Tools/Scripts/webkit-build-directory --gtk" took 0.12s
flatpakutils: [DEBUG] Running in sandbox: flatpak build --die-with-parent --talk-name=org.a11y.Bus --talk-name=org.gtk.vfs --talk-name=org.gtk.vfs.* --bind-mount=/run/shm=/dev/shm --bind-mount=/run/host//tmp=/tmp --bind-mount=/app/webkit=/home/phil/WebKit --bind-mount=/app/webkit/WebKitBuild/Release=/home/phil/WebKit/WebKitBuild/GTK/Release --device=all --device=dri --filesystem=host --share=ipc --share=network --socket=pulseaudio --socket=system-bus --socket=wayland --socket=x11 --system-talk-name=org.a11y.Bus --system-talk-name=org.freedesktop.GeoClue2 --talk-name=org.a11y.Bus --talk-name=org.freedesktop.Flatpak --env=LANG=en_US.UTF-8 --env=GST_INSPECT_NO_COLORS=1 --env=TZ=PST8PDT --env=GTK_MODULES=gail:atk-bridge --env=WAYLAND_DISPLAY=wayland-0 --env=DISPLAY=:0 --env=WEBKIT_TOP_LEVEL=/app/ --env=NUMBER_OF_PROCESSORS=12 --env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so /home/phil/WebKit/WebKitBuild/UserFlatpak /app/webkit/Tools/Scripts/run-webkit-tests --gtk --verbose imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https.html

Using port 'gtk-wk2'
Test configuration: <, x86, release>
Placing test results in /app/webkit/WebKitBuild/Release/layout-test-results
Using Release build
Pixel tests disabled
Regular timeout: 15000, slow test timeout: 75000
Command line: /app/webkit/WebKitBuild/Release/bin/WebKitTestRunner -

Found 1 test; running 1, skipping 0.
                                     
Verbose baseline search path: platform/gtk -> platform/wk2 -> generic

Baseline search path: platform/gtk -> platform/wk2 -> generic

Running 1 test

Running 1 WebKitTestRunner.     

Writing new expected result "imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https-expected.txt"
[1/1] imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https.html failed unexpectedly (-expected.txt was missing)
                                     
0 tests ran as expected, 1 didn't:


Regressions: Unexpected missing results (1)
  imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https.html [ Missing ]

[Philippe Normand]

(In reply to Sergio Villar Senin from comment #0)
> I get the following error when trying to run the tests in a directory where
> all the tests are skipped:
> 
> Command '['flatpak', 'build', '--die-with-parent',
> '--talk-name=org.a11y.Bus', '--talk-name=org.gtk.vfs',
> '--talk-name=org.gtk.vfs.*', '--bind-mount=/run/shm=/dev/shm',
> '--bind-mount=/run/host//tmp=/tmp',
> '--bind-mount=/app/webkit=/home/sergio/checkout/WPE',
> '--bind-mount=/app/webkit/WebKitBuild/Release=/home/sergio/checkout/WPE/
> WebKitBuild/WPE/Release', '--device=all', '--device=dri',
> '--filesystem=host', '--share=ipc', '--share=network',
> '--socket=pulseaudio', '--socket=system-bus', '--socket=wayland',
> '--socket=x11', '--system-talk-name=org.a11y.Bus',
> '--system-talk-name=org.freedesktop.GeoClue2', '--talk-name=org.a11y.Bus',
> '--talk-name=org.freedesktop.Flatpak', '--env=LANG=en_US.UTF-8',
> '--env=TZ=PST8PDT', '--env=GTK_MODULES=gail:atk-bridge',
> '--env=WAYLAND_DISPLAY=wayland-0', '--env=DISPLAY=:0',
> '--env=WEBKIT_TOP_LEVEL=/app/',
> '--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/WebKitBuild/Release/
> lib/libTestRunnerInjectedBundle.so',
> '/home/sergio/checkout/WPE/WebKitBuild/UserFlatpak',
> '/app/webkit/Tools/Scripts/run-webkit-tests', '--wpe',
> 'LayoutTests/imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.
> https.html']' returned non-zero exit status 255

Is this all the command output?

[Philippe Normand]

Hello?

[Sergio Villar Senin]

That's because you're specifying a test. Just use imported/w3c/web-platform-tests/webxr for example.

[Philippe Normand]

Ah OK I understand now that what's bothering you is the "Command...returned non-zero exit status 255" message?

I could display this only for verbose runs if that can help.

[Philippe Normand]

Created attachment 395793 [details]
Patch

[Philippe Normand]

Committed r259862: <https://trac.webkit.org/changeset/259862>

[Radar WebKit Bug Importer]

<rdar://problem/61577006>