[ews] commit-queue should comment on bug and set cq- flag in case of test failures.
Created attachment 393845 [details]
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1593
Comment on attachment 393845 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=393845&action=review
> + self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
Is this the current behavior? If I recall, this logic doesn't apply to flaky tests, but I can see some circumstances where this behavior is undesirable.
(In reply to Jonathan Bedard from comment #3)
> Is this the current behavior? If I recall, this logic doesn't apply to flaky tests.
Yes, I think so. The comment and cq- would be when a test failure is confirmed (test consistently failed in first and second run, and passed in clean-tree-run). Test which were found to be flaky during the run would not affect the result.
Committed r258652: <https://trac.webkit.org/changeset/258652>
This change seems to be working fine.
Patch with test failure: https://ews-build.webkit.org/#/builders/28/builds/63
Flaky test: https://ews-build.webkit.org/#/builders/28/builds/66