Bug 209209 – [CMake] libopus 1.1 its enough for building WebKitGTK with ENABLE_WEB_RTC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Alberto Lopez Perez]

Building WebKitGTK with -DENABLE_WEB_RTC=ON on Ubuntu 18.04 its not longer possible since r258412 

This failure happens:
[...]
-- Using platform-specific CMakeLists: /opt/webkitgtk/nightly/build/Source/JavaScriptCore/shell/PlatformGTK.cmake
-- Using source list file: Sources.txt
-- Using source list file: SourcesGTK.txt
-- Using platform-specific CMakeLists: /opt/webkitgtk/nightly/build/Source/ThirdParty/ANGLE/PlatformGTK.cmake
-- Performing Test CXX_COMPILER_SUPPORTS_-Wno-suggest-attribute=format
-- Performing Test CXX_COMPILER_SUPPORTS_-Wno-suggest-attribute=format - Success
-- Platform-specific CMakeLists not found: /opt/webkitgtk/nightly/build/Source/ThirdParty/gtest/PlatformGTK.cmake
-- Could NOT find LibOpus: Found unsuitable version "1.1.2", but required is at least "1.3" (found /usr/lib/x86_64-linux-gnu/libopus.so)
CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:21 (message):
  libopus is needed for USE_LIBWEBRTC.



libopus 1.1.2 (what ubuntu 18.04 ships) its enough for -DENABLE_WEB_RTC and it was working before r237174 because the check was not working as expected.

[Carlos Alberto Lopez Perez]

Created attachment 393811 [details]
Patch

[Carlos Alberto Lopez Perez]

Created attachment 393812 [details]
Patch

[Konstantin Tokarev]

Did you actually test it?

[Carlos Alberto Lopez Perez]

(In reply to Konstantin Tokarev from comment #3)
> Did you actually test it?

I tested that it builds and that WebRTC WPT related tests pass.

Check:
https://wpt.fyi/results/webrtc?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned

The version of WebKitGTK that its tested on the WPT CI its built for Ubuntu 18.04 in this bot https://build-webkit.igalia.com/builders/GTK%20Linux%2064-bit%20WPT%20Packaging%20%28nightly%20channel%29 And it started to fail building after r258412

Once that bot finish building correctly it uploads the built product to https://webkitgtk.org/built-products/ for later consuming on the WPT CI (taskcluster) that runs currently on Ubuntu 18.04 and runs all the WPT tests.

Beyond that, I did not tested it further. If you know a specific test to try, let me know.

[Konstantin Tokarev]

Comment on attachment 393812 [details]
Patch

I've actually meant something like running WebRTC on some real site, but I guess passing WPT should be enough.

[WebKit Commit Bot]

Comment on attachment 393812 [details]
Patch

Clearing flags on attachment: 393812

Committed r258624: <https://trac.webkit.org/changeset/258624>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.