Bug 209187 - [WKTR] testRunner API that takes in a completion handler should use async IPC
Summary: [WKTR] testRunner API that takes in a completion handler should use async IPC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 209184
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-17 11:02 PDT by Chris Dumez
Modified: 2020-03-17 14:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (19.38 KB, patch)
2020-03-17 11:03 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-03-17 11:02:04 PDT
testRunner API that takes in a completion handler should use async IPC, not sync IPC.
Comment 1 Chris Dumez 2020-03-17 11:03:30 PDT
Created attachment 393767 [details]
Patch
Comment 2 John Wilander 2020-03-17 14:00:58 PDT
Comment on attachment 393767 [details]
Patch

The ios-wk2 bot test failures look unrelated.
Comment 3 Chris Dumez 2020-03-17 14:25:11 PDT
Comment on attachment 393767 [details]
Patch

Clearing flags on attachment: 393767

Committed r258598: <https://trac.webkit.org/changeset/258598>
Comment 4 Chris Dumez 2020-03-17 14:25:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-17 14:26:14 PDT
<rdar://problem/60554986>