Bug 209169 – AXIsolatedTree removal should set all nodes to be removed on AX secondary thread.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

AXIsolatedTree removal should set all nodes to be removed on AX secondary thread.

[Andres Gonzalez]

Created attachment 393726 [details]
Patch

[chris fleizach]

Comment on attachment 393726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393726&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:105
> +    ASSERT(isMainThread);

I think this should be 
ASSERT(isMainThread());

[Andres Gonzalez]

Created attachment 393754 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 393726 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393726&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:105
> > +    ASSERT(isMainThread);
> 
> I think this should be 
> ASSERT(isMainThread());

Corrected, thanks!

[WebKit Commit Bot]

Comment on attachment 393754 [details]
Patch

Clearing flags on attachment: 393754

Committed r258560: <https://trac.webkit.org/changeset/258560>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60545793>

[Darin Adler]

Comment on attachment 393754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393754&action=review

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:105
> +    if (is<RenderMenuList>(renderer))
> +        return !downcast<RenderMenuList>(*renderer).popupIsVisible();
> +    return true;

I like using && in cases like this instead of an if statement.