AXIsolatedTree removal should set all nodes to be removed on AX secondary thread.
Created attachment 393726 [details] Patch
Comment on attachment 393726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393726&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:105 > + ASSERT(isMainThread); I think this should be ASSERT(isMainThread());
Created attachment 393754 [details] Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 393726 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393726&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:105 > > + ASSERT(isMainThread); > > I think this should be > ASSERT(isMainThread()); Corrected, thanks!
Comment on attachment 393754 [details] Patch Clearing flags on attachment: 393754 Committed r258560: <https://trac.webkit.org/changeset/258560>
All reviewed patches have been landed. Closing bug.
<rdar://problem/60545793>
Comment on attachment 393754 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393754&action=review > Source/WebCore/accessibility/AccessibilityMenuList.cpp:105 > + if (is<RenderMenuList>(renderer)) > + return !downcast<RenderMenuList>(*renderer).popupIsVisible(); > + return true; I like using && in cases like this instead of an if statement.