Bug 209166 - [Cocoa] Disable CF prefs direct mode
Summary: [Cocoa] Disable CF prefs direct mode
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-16 19:56 PDT by Per Arne Vollan
Modified: 2020-03-17 09:59 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2020-03-16 20:33 PDT, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2020-03-16 20:58 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.67 KB, patch)
2020-03-16 21:36 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.76 KB, patch)
2020-03-16 22:03 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.86 KB, patch)
2020-03-16 22:34 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (9.47 KB, patch)
2020-03-17 07:14 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-03-16 19:56:35 PDT 
Revert <https://trac.webkit.org/changeset/258064> by disabling the CF prefs direct mode feature, since it caused performance regressions.
Comment 1 Per Arne Vollan 2020-03-16 20:04:18 PDT 
rdar://problem/60517387
Comment 2 Per Arne Vollan 2020-03-16 20:33:34 PDT 
Created attachment 393722 [details]
Patch
Comment 3 Brent Fulgham 2020-03-16 20:45:19 PDT 
Comment on attachment 393722 [details]
Patch

Bummer! r=me
Comment 4 Per Arne Vollan 2020-03-16 20:58:19 PDT 
Created attachment 393724 [details]
Patch
Comment 5 Per Arne Vollan 2020-03-16 20:58:48 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 393722 [details]
> Patch
> 
> Bummer! r=me

Yes! Thanks for reviewing :)
Comment 6 Per Arne Vollan 2020-03-16 21:36:55 PDT 
Created attachment 393727 [details]
Patch
Comment 7 Per Arne Vollan 2020-03-16 22:03:53 PDT 
Created attachment 393729 [details]
Patch
Comment 8 Per Arne Vollan 2020-03-16 22:34:03 PDT 
Created attachment 393730 [details]
Patch
Comment 9 Per Arne Vollan 2020-03-17 07:14:29 PDT 
Created attachment 393750 [details]
Patch
Comment 10 WebKit Commit Bot 2020-03-17 09:59:39 PDT 
Comment on attachment 393750 [details]
Patch

Clearing flags on attachment: 393750

Committed r258557: <https://trac.webkit.org/changeset/258557>