RESOLVED FIXED Bug 209165
ScriptDisallowedScope should disable isEventAllowedInMainThread and isEventDispatchAllowedInSubtree asserts in WebKit1 
https://bugs.webkit.org/show_bug.cgi?id=209165
Summary ScriptDisallowedScope should disable isEventAllowedInMainThread and isEventDi...
Sunny He
Reported 2020-03-16 19:16:44 PDT
rdar://59575816
Attachments
Patch (2.29 KB, patch)
2020-03-16 19:25 PDT, Sunny He 		no flags
DetailsFormatted DiffDiff
Patch (2.28 KB, patch)
2020-03-18 18:27 PDT, Sunny He 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sunny He
Comment 1 2020-03-16 19:25:08 PDT
Created attachment 393721 [details] Patch
Alex Christensen
Comment 2 2020-03-17 23:12:51 PDT
Could you or Ryosuke elaborate on what these problematic design decisions are? On non-Cocoa platforms, isInWebProcess returns a constant. That is problematic. Maybe the time is come for them to implement this.
Ryosuke Niwa
Comment 3 2020-03-18 12:39:29 PDT
(In reply to Alex Christensen from comment #2) > Could you or Ryosuke elaborate on what these problematic design decisions > are? Sync delegate callbacks. > On non-Cocoa platforms, isInWebProcess returns a constant. That is > problematic. Maybe the time is come for them to implement this. Why would it be? Nobody ships WK1 other than macOS, iOS, and Windows ports these days.
Ryosuke Niwa
Comment 4 2020-03-18 12:41:21 PDT
Hm... looks like GTK+ build is failing for an unrelated reason? Let's re-try them.
Ryosuke Niwa
Comment 5 2020-03-18 17:51:19 PDT
Comment on attachment 393721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393721&action=review > Source/WebCore/dom/ScriptDisallowedScope.h:27 > +#include <WebCore/RuntimeApplicationChecks.h> Oh, wait, this is not the right way to include this header. Should be: #icnlude "RuntimeApplicationChecks.h" This is probably why the build failure is happening on GTK+ etc...
Sunny He
Comment 6 2020-03-18 18:27:42 PDT
Created attachment 393930 [details] Patch
EWS
Comment 7 2020-03-19 16:48:24 PDT
Committed r258744: <https://trac.webkit.org/changeset/258744> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393930 [details].
Note You need to log in before you can comment on or make changes to this bug.