Bug 209163 - [GStreamer][WebRTC] Audio is not played from an audio element when the srcObject object has unstarted video tracks
Summary: [GStreamer][WebRTC] Audio is not played from an audio element when the srcObj...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
Depends on:
Reported: 2020-03-16 18:12 PDT by Lauro Moura
Modified: 2021-04-06 06:54 PDT (History)
17 users (show)

See Also:

Patch (11.15 KB, patch)
2021-04-03 04:57 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (11.17 KB, patch)
2021-04-06 06:26 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-03-16 18:12:19 PDT
bug207041 added to MediaPlayerPrivateMediaStreamAVObjC the feature of audio elements playing audio tracks of videos right away instead of waiting for the video to be loaded.

Will mark the test webrtc/audio-video-element-playing.html as failure while this is sorted out (Can't generate an specific GST baseline as the value in the error message can change for each run).
Comment 1 Philippe Normand 2020-06-01 11:09:04 PDT
I have a WIP patch...
Comment 2 Philippe Normand 2021-04-03 04:57:08 PDT
Created attachment 425092 [details]
Comment 3 Xabier Rodríguez Calvar 2021-04-06 05:13:49 PDT
Comment on attachment 425092 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=425092&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:631
> +        if (track->type() == RealtimeMediaSource::Type::Video && !isVideoPlayer)

Nit: I prefer to add booleans first in evaluation cause you can short-circuit some calls for the type(), etc.
Comment 4 Philippe Normand 2021-04-06 06:26:24 PDT
Created attachment 425271 [details]
Comment 5 EWS 2021-04-06 06:53:28 PDT
Committed r275514: <https://commits.webkit.org/r275514>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425271 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-06 06:54:16 PDT