Bug 20916 - http://trac.webkit.org/changeset/36604 was maybe not thread-safe
Summary: http://trac.webkit.org/changeset/36604 was maybe not thread-safe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-18 08:25 PDT by Geoffrey Garen
Modified: 2008-09-26 15:43 PDT (History)
3 users (show)

See Also:


Attachments
patch (2.98 KB, patch)
2008-09-18 08:26 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
patch with changelog (3.44 KB, patch)
2008-09-18 08:29 PDT, Geoffrey Garen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-09-18 08:25:37 PDT
r36604 changed some data on machine to be static, instead of per-machine. Static data is not thread-safe.
Comment 1 Geoffrey Garen 2008-09-18 08:26:03 PDT
Created attachment 23529 [details]
patch
Comment 2 Geoffrey Garen 2008-09-18 08:29:28 PDT
Created attachment 23530 [details]
patch with changelog
Comment 3 Darin Adler 2008-09-18 09:19:23 PDT
Comment on attachment 23530 [details]
patch with changelog

r=me
Comment 4 Geoffrey Garen 2008-09-26 15:43:24 PDT
Committed revision 36973.