Bug 209127 - Remove addHTTPOriginIfNeeded calls
Summary: Remove addHTTPOriginIfNeeded calls
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
Keywords: InRadar
Depends on:
Reported: 2020-03-15 11:34 PDT by Rob Buis
Modified: 2020-03-29 10:34 PDT (History)
6 users (show)

See Also:

Patch (4.33 KB, patch)
2020-03-15 11:35 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2020-03-29 06:10 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-03-15 11:34:34 PDT
Remove addHTTPOriginIfNeeded calls since they are get requests and navigations and the spec [1]
indicates that the Origin header should not be written out, making these calls no-ops.

[1] https://fetch.spec.whatwg.org/#append-a-request-origin-header
Comment 1 Rob Buis 2020-03-15 11:35:55 PDT
Created attachment 393620 [details]
Comment 2 WebKit Commit Bot 2020-03-16 01:11:31 PDT
Comment on attachment 393620 [details]

Clearing flags on attachment: 393620

Committed r258488: <https://trac.webkit.org/changeset/258488>
Comment 3 WebKit Commit Bot 2020-03-16 01:11:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-16 01:12:12 PDT
Comment 5 Rob Buis 2020-03-29 06:10:35 PDT
Reopening to attach new patch.
Comment 6 Rob Buis 2020-03-29 06:10:38 PDT
Created attachment 394865 [details]
Comment 7 Darin Adler 2020-03-29 09:21:06 PDT
Comment on attachment 394865 [details]

Looks fine. Next time I suggest using a new bug report. I don’t think reopening is a good way to handle follow up even though I see a lot of people doing it. I think reopening is a good way to handle trying again rolling out or trying again if the first try did not successfully fix the bug.
Comment 8 Rob Buis 2020-03-29 10:28:07 PDT
Point taken!
Comment 9 EWS 2020-03-29 10:34:22 PDT
Committed r259182: <https://trac.webkit.org/changeset/259182>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394865 [details].