Bug 209122 - [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
Summary: [EWS] Limit number of builds to display in status-bubble hover over message i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-15 05:43 PDT by Aakash Jain
Modified: 2020-03-20 03:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.15 KB, patch)
2020-03-15 05:44 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-15 05:43:58 PDT
Limit number of builds to display in status-bubble hover over message in case of lot of retried builds. Sometimes because of retries, one patch can be retried a lot of times.  e.g.: https://ews-build.webkit.org/#/builders/29/builds/5682 (Bug https://bugs.webkit.org/show_bug.cgi?id=209008)

In such cases status-bubble generation might become slow if the status-bubble shows history from all builds (e.g.: while one of the build is in-progress, or last build was skipped because of patch being obsolete/bug-closing). The slowness is because the hover-over message will become huge, and the calculation itself might take a while because of large number of builds.
Comment 1 Aakash Jain 2020-03-15 05:44:43 PDT
Created attachment 393616 [details]
Patch
Comment 2 Aakash Jain 2020-03-20 03:29:33 PDT
Committed r258757: <https://trac.webkit.org/changeset/258757>
Comment 3 Radar WebKit Bug Importer 2020-03-20 03:30:15 PDT
<rdar://problem/60678169>