Bug 209117 – Add missing checks needed for AppBound Quirk

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

In Bug 208777 I made it possible to turn off InAppBrowserPrivacy quirks, but missed a few places. This patch corrects that oversight.

[Radar WebKit Bug Importer]

<rdar://problem/60460097>

[Brent Fulgham]

Created attachment 393595 [details]
Patch

[John Wilander]

Comment on attachment 393595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review

r=me with comments.

> Source/WebKit/ChangeLog:8
> +

Did you mean to put the same description here as in the WebCore change log?

> Source/WebCore/loader/FrameLoaderClient.h:383
> +    virtual bool needsInAppBrowserPrivacyQuirks() { return false; }

Is there a reason for not making this const?

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:292
> +    bool needsInAppBrowserPrivacyQuirks() final;

This too could be const.

[Brent Fulgham]

Comment on attachment 393595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review

>> Source/WebKit/ChangeLog:8
>> +
> 
> Did you mean to put the same description here as in the WebCore change log?

Whoops! Yes.

>> Source/WebCore/loader/FrameLoaderClient.h:383
>> +    virtual bool needsInAppBrowserPrivacyQuirks() { return false; }
> 
> Is there a reason for not making this const?

Good catch.

[Brent Fulgham]

Created attachment 393596 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 393596 [details]
Patch for landing

Clearing flags on attachment: 393596

Committed r258476: <https://trac.webkit.org/changeset/258476>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.