In Bug 208777 I made it possible to turn off InAppBrowserPrivacy quirks, but missed a few places. This patch corrects that oversight.
<rdar://problem/60460097>
Created attachment 393595 [details] Patch
Comment on attachment 393595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review r=me with comments. > Source/WebKit/ChangeLog:8 > + Did you mean to put the same description here as in the WebCore change log? > Source/WebCore/loader/FrameLoaderClient.h:383 > + virtual bool needsInAppBrowserPrivacyQuirks() { return false; } Is there a reason for not making this const? > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:292 > + bool needsInAppBrowserPrivacyQuirks() final; This too could be const.
Comment on attachment 393595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review >> Source/WebKit/ChangeLog:8 >> + > > Did you mean to put the same description here as in the WebCore change log? Whoops! Yes. >> Source/WebCore/loader/FrameLoaderClient.h:383 >> + virtual bool needsInAppBrowserPrivacyQuirks() { return false; } > > Is there a reason for not making this const? Good catch.
Created attachment 393596 [details] Patch for landing
Comment on attachment 393596 [details] Patch for landing Clearing flags on attachment: 393596 Committed r258476: <https://trac.webkit.org/changeset/258476>
All reviewed patches have been landed. Closing bug.