RESOLVED FIXED Bug 209091
[Cocoa] Only set CF prefs direct mode for the WebContent process 
https://bugs.webkit.org/show_bug.cgi?id=209091
Summary [Cocoa] Only set CF prefs direct mode for the WebContent process
Per Arne Vollan
Reported 2020-03-13 15:53:45 PDT
Currently, we enable CF prefs direct mode in XPCServiceMain. This is incorrect, it should be enabled only in WebContentServiceInitializer.
Attachments
Patch (3.01 KB, patch)
2020-03-13 15:57 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.49 KB, patch)
2020-03-13 16:46 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2020-03-16 08:47 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2020-03-16 10:16 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-03-13 15:55:28 PDT
rdar://problem/60337842
Per Arne Vollan
Comment 2 2020-03-13 15:57:12 PDT
Created attachment 393548 [details] Patch
Brent Fulgham
Comment 3 2020-03-13 15:59:17 PDT
Comment on attachment 393548 [details] Patch Ah! Yes, this is a better place for this. r=me.
Per Arne Vollan
Comment 4 2020-03-13 16:10:35 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 393548 [details] > Patch > > Ah! Yes, this is a better place for this. r=me. Thanks for reviewing!
Per Arne Vollan
Comment 5 2020-03-13 16:46:06 PDT
Created attachment 393556 [details] Patch
Darin Adler
Comment 6 2020-03-15 17:34:50 PDT
Comment on attachment 393556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393556&action=review > Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:62 > + // Enable CF prefs direct mode to avoid connecting to the CF prefs daemon. I would have written a comment more like: // Enable CFPrefs direct mode to avoid unsuccessfully attempting to connect to the daemon and getting blocked by the sandbox.
Per Arne Vollan
Comment 7 2020-03-16 08:47:04 PDT
Created attachment 393655 [details] Patch
Per Arne Vollan
Comment 8 2020-03-16 10:16:43 PDT
Created attachment 393657 [details] Patch
Per Arne Vollan
Comment 9 2020-03-16 10:17:24 PDT
(In reply to Darin Adler from comment #6) > Comment on attachment 393556 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393556&action=review > > > Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:62 > > + // Enable CF prefs direct mode to avoid connecting to the CF prefs daemon. > > I would have written a comment more like: > > // Enable CFPrefs direct mode to avoid unsuccessfully attempting to > connect to the daemon and getting blocked by the sandbox. Fixed. Thanks for reviewing!
Brent Fulgham
Comment 10 2020-03-16 12:02:31 PDT
Comment on attachment 393657 [details] Patch r=me
Per Arne Vollan
Comment 11 2020-03-16 12:06:28 PDT
Comment on attachment 393657 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 12 2020-03-16 12:51:04 PDT
Comment on attachment 393657 [details] Patch Clearing flags on attachment: 393657 Committed r258512: <https://trac.webkit.org/changeset/258512>
WebKit Commit Bot
Comment 13 2020-03-16 12:51:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.