Bug 209090 – Remove unused IPC messages from DrawingAreaProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

Remove the following three unused messages in DrawingAreaProxy:

DrawingAreaProxy::Update
DrawingAreaProxy::DidUpdateBackingStoreState
DrawingAreaProxy::ExitAcceleratedCompositingMode

[Brent Fulgham]

<rdar://problem/60333300>

[Brent Fulgham]

Created attachment 393549 [details]
Patch

[Wenson Hsieh]

Comment on attachment 393549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393549&action=review

> Source/WebKit/UIProcess/DrawingAreaProxy.messages.in:-24
> -    Update(uint64_t stateID, WebKit::UpdateInfo updateInfo)

This one at least appears to be used in Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp :/

[Chris Dumez]

Comment on attachment 393549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393549&action=review

>> Source/WebKit/UIProcess/DrawingAreaProxy.messages.in:-24
>> -    Update(uint64_t stateID, WebKit::UpdateInfo updateInfo)
> 
> This one at least appears to be used in Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp :/

So I guess we should #ifdef it instead.

[Brent Fulgham]

Created attachment 393597 [details]
Patch

[Brent Fulgham]

Created attachment 393656 [details]
Patch

[Wenson Hsieh]

Comment on attachment 393656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393656&action=review

> Source/WebCore/DerivedSources-input.xcfilelist:442
> +$(PROJECT_DIR)/Modules/webxr/NavigatorWebXR.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRBoundedReferenceSpace.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRFrame.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRInputSource.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRInputSourceArray.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRPose.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRReferenceSpace.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRRenderState.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRRigidTransform.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRSession.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRSpace.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRSystem.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRView.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRViewerPose.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRViewport.idl
> +$(PROJECT_DIR)/Modules/webxr/WebXRWebGLLayer.idl
> +$(PROJECT_DIR)/Modules/webxr/XREnvironmentBlendMode.idl
> +$(PROJECT_DIR)/Modules/webxr/XREye.idl
> +$(PROJECT_DIR)/Modules/webxr/XRFrameRequestCallback.idl
> +$(PROJECT_DIR)/Modules/webxr/XRHandedness.idl
> +$(PROJECT_DIR)/Modules/webxr/XRInputSourceEvent.idl
> +$(PROJECT_DIR)/Modules/webxr/XRInputSourcesChangeEvent.idl
> +$(PROJECT_DIR)/Modules/webxr/XRReferenceSpaceEvent.idl
> +$(PROJECT_DIR)/Modules/webxr/XRReferenceSpaceType.idl
> +$(PROJECT_DIR)/Modules/webxr/XRRenderStateInit.idl
> +$(PROJECT_DIR)/Modules/webxr/XRSessionEvent.idl
> +$(PROJECT_DIR)/Modules/webxr/XRSessionInit.idl
> +$(PROJECT_DIR)/Modules/webxr/XRSessionMode.idl
> +$(PROJECT_DIR)/Modules/webxr/XRTargetRayMode.idl
> +$(PROJECT_DIR)/Modules/webxr/XRVisibilityState.idl
> +$(PROJECT_DIR)/Modules/webxr/XRWebGLLayerInit.idl

Looks like https://trac.webkit.org/changeset/258510/webkit takes care of this already.

> Source/WebCore/DerivedSources-output.xcfilelist:2097
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRBoundedReferenceSpace.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRBoundedReferenceSpace.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRFrame.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRFrame.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRInputSource.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRInputSource.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRInputSourceArray.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRInputSourceArray.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRPose.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRPose.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRReferenceSpace.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRReferenceSpace.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRRenderState.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRRenderState.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRRigidTransform.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRRigidTransform.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRSession.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRSession.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRSpace.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRSpace.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRSystem.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRSystem.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRView.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRView.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRViewerPose.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRViewerPose.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRViewport.cpp
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRViewport.h
> +$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebXRWebGLLayer.cpp

(Ditto)

[Brent Fulgham]

Created attachment 393671 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 393671 [details]
Patch for landing

Clearing flags on attachment: 393671

Committed r258513: <https://trac.webkit.org/changeset/258513>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.