Bug 209088 – [CSS Writing Modes] Import css/css-writing-modes from WPT

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

It seems that the LayoutTests doesn't contain css-writing-modes tests at all in the imported directory, those files are necessary for testing CSS properties such as text-orientation.

[Radar WebKit Bug Importer]

<rdar://problem/60437323>

Created attachment 393546 [details]
Patch

Created attachment 393553 [details]
Patch

[Myles C. Maxfield]

I can't comment in the patch itself because it's so large. My only comment: How about titling the bug "Import css/css-writing-modes from WPT"?

Created attachment 393558 [details]
Patch for committing

[EWS]

Comment on attachment 393558 [details]
Patch for committing

Rejecting attachment 393558 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 393558 [details]
Patch for committing

Rejecting attachment 393558 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 393558, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13341166

Created attachment 393570 [details]
Patch for committing

[Myles C. Maxfield]

Comment on attachment 393570 [details]
Patch for committing

In the future, please use "Myles C. Maxfield"

[WebKit Commit Bot]

Comment on attachment 393570 [details]
Patch for committing

Rejecting attachment 393570 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 393570, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
ported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-006.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-008-expected.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-008.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-010-expected.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-010.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-011-expected.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-011.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-015-expected.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-015.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-root-expected.txt
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-root.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-scroll-offset-vertical-lr-expected.txt
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-scroll-offset-vertical-lr.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-scroll-offset-vertical-rl-expected.txt
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-scroll-offset-vertical-rl.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-horizontal-001l-expected.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-horizontal-001l.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-horizontal-001r-expected.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-horizontal-001r.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-001-expected.txt
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-001.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-sideways-lr-001-expected.txt
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-sideways-lr-001.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-sideways-rl-001-expected.txt
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-sideways-rl-001.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-svg1-001-expected.txt
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-parsing-svg1-001.html
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-lr-002-expected.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-lr-002.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-rl-001-expected.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-rl-001.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-rl-002-expected.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-rl-002.xht
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-rl-003-expected.htm
	A	LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/writing-mode-vertical-rl-003.htm
	M	LayoutTests/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date
W: 23fe8aff4c70caece1e47234baecb63c93028b07 and refs/remotes/origin/master differ, using rebase:
:040000 040000 13393f41d126e8f5e02c69124c1de79643a1a8df faa930175bf1f627b95b2085415cfd51e1758370 M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   723de532928..445252167cf  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 258460 = 723de53292887a83fa81ebf05e47a9c78842c819
r258461 = 445252167cfd068082f7a473cdb304948b16355e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Total errors found: 0 in 1 files

Full output: https://webkit-queues.webkit.org/results/13341283

[Aakash Jain]

Please make sure to look into layout test failure before commiting. ios-wk2 shows 30+ failures in both the patches. If the test needs rebaselining, please do so in this patch itself. It is not acceptable to knowingly break the tests.

Also mac-debug-wk1 seems to be failing in a suspicious manner, causing the clean tree run to also fail with 30+ failures, e.g.: 
e.g.: 
https://ews-build.webkit.org/#/builders/32/builds/5203
https://ews-build.webkit.org/#/builders/32/builds/5205
https://ews-build.webkit.org/#/builders/32/builds/5210

Please have a look.

Created attachment 393793 [details]
Patch

Created attachment 393804 [details]
Patch

Created attachment 393809 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 393809 [details]
Patch

I already reviewed this; no need for another r+.

[Myles C. Maxfield]

Committed r258661: <https://trac.webkit.org/changeset/258661>