Bug 209086 – Color Picker crashes on touch

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Color Picker crashes on touch

[Megan Gardner]

Created attachment 393662 [details]
Patch

[Wenson Hsieh]

Comment on attachment 393662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393662&action=review

> LayoutTests/fast/forms/color/color-input-activate-crash.html:13
> +		if (!testRunner.runUIScript)

Nit - spaces instead of tabs.

> LayoutTests/fast/forms/color/color-input-activate-crash.html:16
> +	    var input = document.getElementById('colorInput');

Nit - it looks like there are a mix of spaces and tabs here.

> LayoutTests/fast/forms/color/color-input-activate-crash.html:19
> +		await UIHelper.activateElementAndWaitForInputSession(input);
> +	    document.getElementById('result').innerHTML = 'PASS: Test did not crash';
> +	    testRunner.notifyDone();

Ditto with these lines.

> LayoutTests/fast/forms/color/color-input-activate-crash.html:22
> +	window.addEventListener('load', runTest, false);

Ditto.

[Megan Gardner]

Created attachment 393664 [details]
Patch

[Wenson Hsieh]

Comment on attachment 393664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393664&action=review

> LayoutTests/fast/forms/color/color-input-activate-crash.html:17
> +        wait UIHelper.activateElementAndWaitForInputSession(input);

wait => await?

[Megan Gardner]

Created attachment 393666 [details]
Patch

[Darin Adler]

Comment on attachment 393666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393666&action=review

> Source/WebCore/ChangeLog:8
> +        Vector sizing lost in refactor. Not perfomance sensitive code, so just expanding vector as needed.

Thanks for fixing my mistake!

There are really two questions about using append. One you have answered here. The other is whether the vector lives a long time -- if it did we would want to make sure it doesn’t use a lot of space. I think it does not live a long time.

If the vector did live a long time, there are two ways we could deal with that:

1) Less effective: Add a call to suggestions.shrinkToFit() after the loop.

2) More effective: Leave this using uncheckedAppend and add this line of code before the loop:

    suggestions.reserveInitialCapacity(std::distance(dataList->suggestions().begin(), { }));

I’m going to assume it does not live a long time.

[WebKit Commit Bot]

Comment on attachment 393666 [details]
Patch

Clearing flags on attachment: 393666

Committed r258516: <https://trac.webkit.org/changeset/258516>

[Radar WebKit Bug Importer]

<rdar://problem/60512626>