Bug 209079 – [ Mac ] fast/animation/request-animation-frame-timestamps.html is flaky failing.

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Jason Lawrence]

fast/animation/request-animation-frame-timestamps.html

Description:
This test is flaky failing on Mac. The flaky failures go back to November 2019. 

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fmedia%2Fuser-gesture-preserved-across-xmlhttprequest.html&platform=mac

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/fast/animation/request-animation-frame-timestamps-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/fast/animation/request-animation-frame-timestamps-actual.txt
@@ -3,10 +3,10 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+FAIL firstTimestamp should be defined. Was undefined
 PASS firstTimestamp is defined.
 PASS secondTimestamp is defined.
 PASS firstTimestamp is secondTimestamp
-PASS firstTimestamp is defined.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Radar WebKit Bug Importer]

<rdar://problem/60434603>

[Jason Lawrence]

I have marked this test as failing while this issue is investigated here: https://trac.webkit.org/changeset/258435/webkit

[Said Abou-Hallawa]

Created attachment 398452 [details]
Patch

[Said Abou-Hallawa]

This os the correct history link. The above one is for the test http/tests/media/user-gesture-preserved-across-xmlhttprequest.html:

https://results.webkit.org/?suite=layout-tests&test=fast%2Fanimation%2Frequest-animation-frame-timestamps.html&platform=mac

[Said Abou-Hallawa]

Created attachment 398476 [details]
Patch

[Said Abou-Hallawa]

Created attachment 398482 [details]
Patch

[Antoine Quint]

Comment on attachment 398482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398482&action=review

> LayoutTests/fast/animation/request-animation-frame-timestamps.html:12
> +        while (Date.now()-start < millis) {}

Could you use `performance.now()` here instead?

> LayoutTests/fast/animation/request-animation-frame-timestamps.html:17
> +            window.requestAnimationFrame(function(timestamp) {

You're mixing arrow-syntax and `function`, could you use a consistent style?

> LayoutTests/fast/animation/request-animation-frame-timestamps.html:37
> +    Promise.all([firstRequestAnimationFrame(), secondRequestAnimationFrame()]).then((timestamps) => {

Nit: no need for the `()` around `timestamps`. You could also use `await` for Promise.all() instead of `then()`.

[Said Abou-Hallawa]

Created attachment 398532 [details]
Patch

[EWS]

Committed r261193: <https://trac.webkit.org/changeset/261193>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398532 [details].