Bug 209061 - Remove the use of empty WebRTC sources for receiver tracks
Summary: Remove the use of empty WebRTC sources for receiver tracks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-13 10:25 PDT by youenn fablet
Modified: 2020-03-16 06:16 PDT (History)
11 users (show)

See Also:

Attachments
Patch (20.39 KB, patch)
2020-03-13 10:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (30.07 KB, patch)
2020-03-16 02:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (30.07 KB, patch)
2020-03-16 04:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-13 10:25:27 PDT 
Remove the use of empty WebRTC sources for receiver tracks
Comment 1 youenn fablet 2020-03-13 10:27:04 PDT 
Created attachment 393497 [details]
Patch
Comment 2 youenn fablet 2020-03-16 02:07:24 PDT 
Created attachment 393638 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2020-03-16 03:06:05 PDT 
Comment on attachment 393638 [details]
Patch for landing

Rejecting attachment 393638 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 393638, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13342388
Comment 4 youenn fablet 2020-03-16 04:10:54 PDT 
Created attachment 393645 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-03-16 06:15:14 PDT 
Comment on attachment 393645 [details]
Patch for landing

Clearing flags on attachment: 393645

Committed r258493: <https://trac.webkit.org/changeset/258493>
Comment 6 WebKit Commit Bot 2020-03-16 06:15:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-16 06:16:15 PDT 
<rdar://problem/60492804>