Bug 209060 - [ews] run FindModifiedChangeLogs early in the build
Summary: [ews] run FindModifiedChangeLogs early in the build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-13 10:24 PDT by Aakash Jain
Modified: 2020-03-15 11:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2020-03-13 10:27 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-13 10:24:32 PDT
[ews] run FindModifiedChangeLogs build-step early in the build. This would reduce the duration between updating to ToT and committing the patch.
Comment 1 Aakash Jain 2020-03-13 10:27:17 PDT
Created attachment 393498 [details]
Patch
Comment 2 Jonathan Bedard 2020-03-13 11:51:30 PDT
Comment on attachment 393498 [details]
Patch

Does it make sense to do this before compiling and testing? Or should we do it after compiling and testing, but before updating?
Comment 3 Aakash Jain 2020-03-13 11:59:21 PDT
(In reply to Jonathan Bedard from comment #2)
> Does it make sense to do this before compiling and testing? Or should we do it after compiling and testing, but before updating?
Probably doesn't make much difference. Might be slightly better before compiling, just after applying the patch (since git status would be based on only patch contents).
Comment 4 WebKit Commit Bot 2020-03-13 12:33:43 PDT
Comment on attachment 393498 [details]
Patch

Clearing flags on attachment: 393498

Committed r258420: <https://trac.webkit.org/changeset/258420>
Comment 5 WebKit Commit Bot 2020-03-13 12:33:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-13 12:34:16 PDT
<rdar://problem/60428905>
Comment 7 Aakash Jain 2020-03-15 11:05:46 PDT
This change should reduce the chances of issues like https://bugs.webkit.org/show_bug.cgi?id=209125 (where landing failed, because during the time repo was updated to ToT and patch was attempted to be landed, there was another commit which modified similar files).