Bug 209038 - Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
Summary: Pull in JS tests from "Internal" when there are "Internal" tests in an adjace...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-12 21:04 PDT by Saam Barati
Modified: 2020-03-13 00:25 PDT (History)
10 users (show)

See Also:

Attachments
patch (1.51 KB, patch)
2020-03-12 21:39 PDT, Saam Barati 		keith_miller: review+
Details | Formatted Diff | Diff
patch (1.48 KB, patch)
2020-03-12 21:41 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (1.48 KB, patch)
2020-03-12 21:45 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-03-12 21:04:52 PDT 
...
Comment 1 Saam Barati 2020-03-12 21:39:58 PDT 
Created attachment 393454 [details]
patch
Comment 2 Keith Miller 2020-03-12 21:40:30 PDT 
Comment on attachment 393454 [details]
patch

r=me
Comment 3 Saam Barati 2020-03-12 21:40:42 PDT 
Comment on attachment 393454 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393454&action=review

> Tools/Scripts/run-javascriptcore-tests:684
> +        @testList = ();

oops, will fix
Comment 4 Keith Miller 2020-03-12 21:41:07 PDT 
Comment on attachment 393454 [details]
patch

lol whoops! r+ for realz
Comment 5 Saam Barati 2020-03-12 21:41:26 PDT 
Created attachment 393455 [details]
patch
Comment 6 Saam Barati 2020-03-12 21:45:29 PDT 
Created attachment 393457 [details]
patch for landing
Comment 7 WebKit Commit Bot 2020-03-13 00:24:40 PDT 
Comment on attachment 393457 [details]
patch for landing

Clearing flags on attachment: 393457

Committed r258385: <https://trac.webkit.org/changeset/258385>
Comment 8 WebKit Commit Bot 2020-03-13 00:24:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-03-13 00:25:17 PDT 
<rdar://problem/60407614>