I made a mistake in the handling of preferences related to the IsInAppBrowserPrivacyEnabled and the quirk flag, which led to some code not executing when expected. This patch does the following: 1. Uses the correct naming scheme for WebKit Internal Debug flags. 2. Adds calls 'setIsNavigatingToAppBoundDomain' in WebPageProxy::decidePolicyForNewWindowAction and WebPageProxy::decidePolicyForResponseShared, which were missed previously. 3. Updates the local quirk state in WebPage when page settings change.
<rdar://problem/60396298>
Created attachment 393434 [details] Patch
Created attachment 393436 [details] Patch
Comment on attachment 393436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393436&action=review > Source/WebKit/ChangeLog:10 > + and the quirk flag, which led to some code not executing when expected. Would be nice with a link to the revision or bug where the mistake was made. > Source/WebKit/ChangeLog:15 > + 'WebKitDebug', not 'WebKitInternal' or 'WebKitInternalDebug'. I don’t know these by heart so I trust you made doubly sure this time. :)
Comment on attachment 393436 [details] Patch Clearing flags on attachment: 393436 Committed r258379: <https://trac.webkit.org/changeset/258379>
All reviewed patches have been landed. Closing bug.