Bug 209031 - Correct preference handling and naming conventions in AppBound browsing preferences
Summary: Correct preference handling and naming conventions in AppBound browsing prefe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-12 17:56 PDT by Brent Fulgham
Modified: 2020-03-12 20:09 PDT (History)
6 users (show)

See Also:


Attachments
Patch (11.55 KB, patch)
2020-03-12 18:03 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (7.43 KB, patch)
2020-03-12 18:20 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-03-12 17:56:05 PDT
I made a mistake in the handling of preferences related to the IsInAppBrowserPrivacyEnabled and the quirk flag, which led to some code not executing when expected.

This patch does the following:

1. Uses the correct naming scheme for WebKit Internal Debug flags.
2. Adds calls 'setIsNavigatingToAppBoundDomain' in WebPageProxy::decidePolicyForNewWindowAction and WebPageProxy::decidePolicyForResponseShared, which were missed previously.
3. Updates the local quirk state in WebPage when page settings change.
Comment 1 Radar WebKit Bug Importer 2020-03-12 17:56:40 PDT
<rdar://problem/60396298>
Comment 2 Brent Fulgham 2020-03-12 18:03:03 PDT
Created attachment 393434 [details]
Patch
Comment 3 Brent Fulgham 2020-03-12 18:20:07 PDT
Created attachment 393436 [details]
Patch
Comment 4 John Wilander 2020-03-12 19:10:01 PDT
Comment on attachment 393436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393436&action=review

> Source/WebKit/ChangeLog:10
> +        and the quirk flag, which led to some code not executing when expected.

Would be nice with a link to the revision or bug where the mistake was made.

> Source/WebKit/ChangeLog:15
> +           'WebKitDebug', not 'WebKitInternal' or 'WebKitInternalDebug'.

I don’t know these by heart so I trust you made doubly sure this time. :)
Comment 5 WebKit Commit Bot 2020-03-12 20:09:49 PDT
Comment on attachment 393436 [details]
Patch

Clearing flags on attachment: 393436

Committed r258379: <https://trac.webkit.org/changeset/258379>
Comment 6 WebKit Commit Bot 2020-03-12 20:09:51 PDT
All reviewed patches have been landed.  Closing bug.