Bug 209026 - [iOS WK2] Some pointerevents tests time out
Summary: [iOS WK2] Some pointerevents tests time out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-12 16:21 PDT by Simon Fraser (smfr)
Modified: 2020-03-13 10:17 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.41 KB, patch)
2020-03-12 16:24 PDT, Simon Fraser (smfr)
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-03-12 16:21:21 PDT
[iOS WK2] Some pointerevents tests time out
Comment 1 Simon Fraser (smfr) 2020-03-12 16:24:49 PDT
Created attachment 393427 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-03-12 16:24:53 PDT
<rdar://problem/60338691>
Comment 3 Wenson Hsieh 2020-03-12 16:55:31 PDT
Comment on attachment 393427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review

> LayoutTests/pointerevents/utils.js:146
>              setTimeout(resolve, durationInSeconds * 1000)

Not for this patch, but it looks like we should fix this to actually listen for the zooming UIScriptController callbacks to know when the zooming animation is done instead of having a hard-coded timeout.

> LayoutTests/pointerevents/utils.js:231
> +        console.log(script);

Was this console.log intended?
Comment 4 Antoine Quint 2020-03-13 00:48:12 PDT
Comment on attachment 393427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review

> LayoutTests/pointerevents/utils.js:230
> +        let script = `uiController.${command}(${args}, () => uiController.uiScriptComplete());`;

You could use `const` here instead of `let`.
Comment 5 Simon Fraser (smfr) 2020-03-13 10:17:27 PDT
https://trac.webkit.org/changeset/258406/webkit