RESOLVED FIXED209026
[iOS WK2] Some pointerevents tests time out 
https://bugs.webkit.org/show_bug.cgi?id=209026
Summary [iOS WK2] Some pointerevents tests time out
Simon Fraser (smfr)
Reported 2020-03-12 16:21:21 PDT
[iOS WK2] Some pointerevents tests time out
Attachments
Patch (4.41 KB, patch)
2020-03-12 16:24 PDT, Simon Fraser (smfr) 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-03-12 16:24:49 PDT
Created attachment 393427 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-03-12 16:24:53 PDT
<rdar://problem/60338691>
Wenson Hsieh
Comment 3 2020-03-12 16:55:31 PDT
Comment on attachment 393427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review > LayoutTests/pointerevents/utils.js:146 > setTimeout(resolve, durationInSeconds * 1000) Not for this patch, but it looks like we should fix this to actually listen for the zooming UIScriptController callbacks to know when the zooming animation is done instead of having a hard-coded timeout. > LayoutTests/pointerevents/utils.js:231 > + console.log(script); Was this console.log intended?
Antoine Quint
Comment 4 2020-03-13 00:48:12 PDT
Comment on attachment 393427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review > LayoutTests/pointerevents/utils.js:230 > + let script = `uiController.${command}(${args}, () => uiController.uiScriptComplete());`; You could use `const` here instead of `let`.
Simon Fraser (smfr)
Comment 5 2020-03-13 10:17:27 PDT
https://trac.webkit.org/changeset/258406/webkit
Note You need to log in before you can comment on or make changes to this bug.