Bug 209019 – -Wredundant-move in CSSPropertyParserHelpers.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Michael Catanzaro]

In file included from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebCore/config.h:56,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParser.cpp:30,
                 from DerivedSources/WebCore/unified-sources/UnifiedSource-2f84417a-16.cpp:1:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: In function ‘WTF::RefPtr<WebCore::CSSValue> WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient(WebCore::CSSParserTokenRange&, WebCore::CSSParserMode, WebCore::CSSGradientRepeat)’:
DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: warning: redundant move in return statement [-Wredundant-move]
  495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’
 1176 |     return WTFMove(result);
      |            ^~~~~~~
DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: note: remove ‘std::move’ call
  495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’
 1176 |     return WTFMove(result);
      |            ^~~~~~~

[Michael Catanzaro]

Created attachment 393411 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 393411 [details]
Patch

Clearing flags on attachment: 393411

Committed r258392: <https://trac.webkit.org/changeset/258392>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60412242>