Bug 209019 - -Wredundant-move in CSSPropertyParserHelpers.cpp
Summary: -Wredundant-move in CSSPropertyParserHelpers.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-12 13:52 PDT by Michael Catanzaro
Modified: 2020-03-13 03:32 PDT (History)
10 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2020-03-12 13:54 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-03-12 13:52:30 PDT
In file included from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebCore/config.h:56,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParser.cpp:30,
                 from DerivedSources/WebCore/unified-sources/UnifiedSource-2f84417a-16.cpp:1:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: In function ‘WTF::RefPtr<WebCore::CSSValue> WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient(WebCore::CSSParserTokenRange&, WebCore::CSSParserMode, WebCore::CSSGradientRepeat)’:
DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: warning: redundant move in return statement [-Wredundant-move]
  495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’
 1176 |     return WTFMove(result);
      |            ^~~~~~~
DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: note: remove ‘std::move’ call
  495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’
 1176 |     return WTFMove(result);
      |            ^~~~~~~
Comment 1 Michael Catanzaro 2020-03-12 13:54:27 PDT
Created attachment 393411 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-13 03:31:50 PDT
Comment on attachment 393411 [details]
Patch

Clearing flags on attachment: 393411

Committed r258392: <https://trac.webkit.org/changeset/258392>
Comment 3 WebKit Commit Bot 2020-03-13 03:31:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-13 03:32:15 PDT
<rdar://problem/60412242>