Bug 209010 - Cache the ScrollView platformWidget to avoid [WebAccessibilityObjectWrapper scrollViewParent] hitting the main thread too often.
Summary: Cache the ScrollView platformWidget to avoid [WebAccessibilityObjectWrapper s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-12 12:38 PDT by Andres Gonzalez
Modified: 2020-03-12 14:13 PDT (History)
10 users (show)

See Also:


Attachments
Patch (13.32 KB, patch)
2020-03-12 12:56 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-03-12 12:38:52 PDT
Cache the ScrollView platformWidget to avoid [WebAccessibilityObjectWrapper scrollViewParent] hitting the main thread too often.
Comment 1 Andres Gonzalez 2020-03-12 12:56:52 PDT
Created attachment 393402 [details]
Patch
Comment 2 chris fleizach 2020-03-12 13:10:30 PDT
Comment on attachment 393402 [details]
Patch

this looks like it will work. holding onto a NSView off the main thread shouldn't be problematic in and of itself. however, if AppKit makes ax calls on that object outside of WebKit it might require a change in AppKit
Comment 3 WebKit Commit Bot 2020-03-12 14:12:18 PDT
Comment on attachment 393402 [details]
Patch

Clearing flags on attachment: 393402

Committed r258356: <https://trac.webkit.org/changeset/258356>
Comment 4 WebKit Commit Bot 2020-03-12 14:12:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-12 14:13:14 PDT
<rdar://problem/60386610>