Bug 209000 – Resource load statistics data summary should return all third party data

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

It would be more informative to return all third party data, not just prevalent domains.

[Kate Cheney]

<rdar://problem/60348306>

[Kate Cheney]

Created attachment 393383 [details]
Patch

[John Wilander]

Comment on attachment 393383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393383&action=review

r=me. Please address my comment on the cookie blocking mode.

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:844
> +        || sortedStatistics.bindText(1, "%")

I think this should be made conditional on the configured WebCore::ThirdPartyCookieBlockingMode. If == WebCore::ThirdPartyCookieBlockingMode::All, send back all third party data, otherwise keep the old behavior. You already have a thirdPartyCookieBlockingMode() getter in the ResourceLoadStatisticsStore base class. Then your API tests might have to enable WebCore::ThirdPartyCookieBlockingMode::All if they aren't already running under that configuration.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:986
> +    // Set two third parties to be prevalent, leave evil1.com as non-prevalent to ensure

Personally, I'd prefer not to call prevalent domains "evil" since there's nothing inherently evil about them. But I know it's existing code.

[Kate Cheney]

Created attachment 393405 [details]
Patch

[Kate Cheney]

(In reply to katherine_cheney from comment #4)
> Created attachment 393405 [details]
> Patch

Thanks John! Made these changes.

Waiting on EWS before cq+

[WebKit Commit Bot]

Comment on attachment 393405 [details]
Patch

Clearing flags on attachment: 393405

Committed r258357: <https://trac.webkit.org/changeset/258357>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60387086>