Bug 20900 - More JIT code generation for op_call
Summary: More JIT code generation for op_call
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-17 11:13 PDT by Gavin Barraclough
Modified: 2008-09-17 12:30 PDT (History)
0 users

See Also:

Attachments
The patch (8.39 KB, patch)
2008-09-17 11:48 PDT, Gavin Barraclough 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-09-17 11:13:59 PDT 
Optimizations for op_call in CTI.  Move check for (ctiCode == 0) into JIT code, move copying of scopeChain for CodeBlocks that needFullScopeChain into head of functions, instead of checking prior to making the call.

3% on v8-tests (4% on richards, 6% in delta-blue)
Comment 1 Gavin Barraclough 2008-09-17 11:48:29 PDT 
Created attachment 23505 [details]
The patch
Comment 2 Geoffrey Garen 2008-09-17 12:22:02 PDT 
Comment on attachment 23505 [details]
The patch

r=me, with some comments on irc.
Comment 3 Gavin Barraclough 2008-09-17 12:30:53 PDT 
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/VM/CTI.cpp
Sending        JavaScriptCore/VM/Machine.cpp
Sending        JavaScriptCore/VM/Machine.h
Transmitting file data ....
Committed revision 36544.