RESOLVED FIXED 208996
Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on the main thread. 
https://bugs.webkit.org/show_bug.cgi?id=208996
Summary Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on th...
Andres Gonzalez
Reported 2020-03-12 07:53:55 PDT
Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on the main thread.
Attachments
Patch (3.30 KB, patch)
2020-03-12 07:56 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-03-12 07:56:57 PDT
Created attachment 393376 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-12 12:07:00 PDT
Comment on attachment 393376 [details] Patch Clearing flags on attachment: 393376 Committed r258349: <https://trac.webkit.org/changeset/258349>
WebKit Commit Bot
Comment 3 2020-03-12 12:07:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-12 12:07:17 PDT
<rdar://problem/60381174>
Darin Adler
Comment 5 2020-03-12 12:28:13 PDT
Comment on attachment 393376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393376&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2830 > + return Accessibility::retrieveAutoreleasedValueFromMainThread<id>([protectedSelf = RetainPtr<WebAccessibilityObjectWrapper>(self)] () -> RetainPtr<id> { Maybe we can write this more elegantly using the retainPtr helper function? [protectedSelf = retainPtr(self)]
Andres Gonzalez
Comment 6 2020-03-12 13:26:58 PDT
(In reply to Darin Adler from comment #5) > Comment on attachment 393376 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393376&action=review > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2830 > > + return Accessibility::retrieveAutoreleasedValueFromMainThread<id>([protectedSelf = RetainPtr<WebAccessibilityObjectWrapper>(self)] () -> RetainPtr<id> { > > Maybe we can write this more elegantly using the retainPtr helper function? > > [protectedSelf = retainPtr(self)] Agree, I'll make a separate change with a sweep through all the instances of this construct. Thanks.
Note You need to log in before you can comment on or make changes to this bug.