Bug 20899 - should not expose <table> as AXTable if there is an ARIA role
Summary: should not expose <table> as AXTable if there is an ARIA role
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-17 10:28 PDT by chris fleizach
Modified: 2008-09-18 15:55 PDT (History)
0 users

See Also:

Attachments
if <table> has an ARIA role, then it should appear as an AXTable (43.37 KB, patch)
2008-09-18 15:02 PDT, chris fleizach 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2008-09-17 10:28:50 PDT 
if a <Table> object has an ARIA role of something other than table, it should not be exposed as an AXTable
Comment 1 chris fleizach 2008-09-18 15:02:19 PDT 
Created attachment 23540 [details]
if <table> has an ARIA role, then it should appear as an AXTable
Comment 2 Sam Weinig 2008-09-18 15:36:10 PDT 
Comment on attachment 23540 [details]
if <table> has an ARIA role, then it should appear as an AXTable

-    if (!isDataTable()) {
-        AccessibilityRenderObject::addChildren();
-        return;
-    }
+    if (!isDataTable())
+        return AccessibilityRenderObject::addChildren();
We try and not return an function with a void return value, unless it is necessary for templates to work.
Comment 3 chris fleizach 2008-09-18 15:38:34 PDT 
will change. figured i could save 2 lines of code that way
Comment 4 Beth Dakin 2008-09-18 15:48:36 PDT 
Comment on attachment 23540 [details]
if <table> has an ARIA role, then it should appear as an AXTable

Looks good!