Bug 208968 - Non-unified build fixes early March 2020 edition Take 2
Summary: Non-unified build fixes early March 2020 edition Take 2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-11 19:18 PDT by Don Olmstead
Modified: 2020-03-15 12:18 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.45 KB, patch)
2020-03-11 19:25 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2020-03-11 19:28 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-03-11 19:18:14 PDT 
This is the song that doesn't end.
Yes, it goes on and on my friend.
Some people started singing it, not knowing what it was,
And they'll continue singing it forever just because...
Comment 1 Don Olmstead 2020-03-11 19:25:22 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-03-11 19:28:49 PDT 
Created attachment 393328 [details]
Patch
Comment 3 WebKit Commit Bot 2020-03-11 20:19:13 PDT 
Comment on attachment 393328 [details]
Patch

Clearing flags on attachment: 393328

Committed r258310: <https://trac.webkit.org/changeset/258310>
Comment 4 WebKit Commit Bot 2020-03-11 20:19:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-11 20:20:18 PDT 
<rdar://problem/60354166>
Comment 6 Darin Adler 2020-03-15 12:18:57 PDT 
Comment on attachment 393328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393328&action=review

> Source/WebCore/editing/TextIterator.h:30
> +#include "SimpleRange.h"

Oh, no, really!? We definitely don’t want TextIterator.h to include SimpleRange.h.

It’s the .cpp files that need it that should be including it. I know there could be a lot of them, but please don’t add this to the header like this.