Bug 208965 - [GPUP] Add entry points for non-Cocoa ports
Summary: [GPUP] Add entry points for non-Cocoa ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 206697
  Show dependency tree / graph
 
Reported: 2020-03-11 18:16 PDT by Don Olmstead
Modified: 2020-03-11 19:56 PDT (History)
8 users (show)

See Also:

Attachments
Patch (15.36 KB, patch)
2020-03-11 18:52 PDT, Don Olmstead 		mcatanzaro: review+
Details | Formatted Diff | Diff
Patch (15.32 KB, patch)
2020-03-11 19:06 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-03-11 18:16:50 PDT 
Add an entry point for non-Cocoa ports.
Comment 1 Don Olmstead 2020-03-11 18:52:41 PDT 
Created attachment 393325 [details]
Patch
Comment 2 Michael Catanzaro 2020-03-11 19:04:00 PDT 
Comment on attachment 393325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393325&action=review

Entry points are better than no entry points!

> Source/WebKit/GPUProcess/EntryPoint/win/GPUProcessMain.cpp:30
> +#include <stdio.h>
> +#include <windows.h>

Surely you don't need these.
Comment 3 Don Olmstead 2020-03-11 19:06:33 PDT 
Created attachment 393326 [details]
Patch
Comment 4 WebKit Commit Bot 2020-03-11 19:55:50 PDT 
Comment on attachment 393326 [details]
Patch

Clearing flags on attachment: 393326

Committed r258309: <https://trac.webkit.org/changeset/258309>
Comment 5 WebKit Commit Bot 2020-03-11 19:55:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-11 19:56:16 PDT 
<rdar://problem/60353614>