Bug 208964 - [Curl] sort out MS vs Seconds confusion in Cookies
Summary: [Curl] sort out MS vs Seconds confusion in Cookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Windows 10
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-11 17:49 PDT by Pavel Feldman
Modified: 2020-03-12 07:10 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.57 KB, patch)
2020-03-11 17:53 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2020-03-11 17:49:53 PDT 
Cookie parser is currently putting seconds into Cookies::expires instead of milliseconds. Fixing it and using consistent time methods around the changed code.
Comment 1 Pavel Feldman 2020-03-11 17:53:42 PDT 
Created attachment 393318 [details]
Patch
Comment 2 Pavel Feldman 2020-03-11 17:56:34 PDT 
- It all started in parseCookieAttributes where seconds instead of millis were put into cookies.expires.
- Then searchCookies was multiplying it by 1000 on fetch from DB.
- Additionally datetime('now') is returning 2020 for me, so I'm moving it to the wall time comparison.
Comment 3 WebKit Commit Bot 2020-03-12 07:09:46 PDT 
Comment on attachment 393318 [details]
Patch

Clearing flags on attachment: 393318

Committed r258325: <https://trac.webkit.org/changeset/258325>
Comment 4 WebKit Commit Bot 2020-03-12 07:09:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-12 07:10:16 PDT 
<rdar://problem/60369754>