Bug 208959 - Add ref test for apple pay button corner radius change
Summary: Add ref test for apple pay button corner radius change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Mouchtaris
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-11 17:07 PDT by Nikos Mouchtaris
Modified: 2020-03-25 12:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.40 KB, patch)
2020-03-11 17:11 PDT, Nikos Mouchtaris
no flags Details | Formatted Diff | Diff
Patch (4.17 KB, patch)
2020-03-25 12:23 PDT, Nikos Mouchtaris
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Mouchtaris 2020-03-11 17:07:51 PDT
Add ref test for apple pay button corner radius change
Comment 1 Nikos Mouchtaris 2020-03-11 17:11:53 PDT
Created attachment 393311 [details]
Patch
Comment 2 Andy Estes 2020-03-25 12:15:17 PDT
Comment on attachment 393311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393311&action=review

> LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius-expected-mismatch.html:5
> +    <title>Test rendering Apple Pay buttons in version 4</title>

I'd remove the "in version 4".

> LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius.html:5
> +    <title>Test rendering Apple Pay buttons in version 4</title>

Ditto.
Comment 3 Nikos Mouchtaris 2020-03-25 12:23:51 PDT
Created attachment 394523 [details]
Patch
Comment 4 EWS 2020-03-25 12:49:44 PDT
Committed r259004: <https://trac.webkit.org/changeset/259004>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394523 [details].
Comment 5 Radar WebKit Bug Importer 2020-03-25 12:50:14 PDT
<rdar://problem/60885268>