Bug 208958 - [GPUP] Add special handling of MediaTime within message generator
Summary: [GPUP] Add special handling of MediaTime within message generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 206697
  Show dependency tree / graph
 
Reported: 2020-03-11 17:06 PDT by Don Olmstead
Modified: 2020-03-11 19:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2020-03-11 17:20 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-03-11 17:06:33 PDT 
GPU Process added MediaTime to messages.in files. The messages.py script wasn't updated for special handling of this.

Pretty sure the only reason this works is because of a .cpp file being included in a unified build. For non-unified builds the following happens

In file included from ../../Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:35:
WebKit/DerivedSources\MediaPlayerPrivateRemoteMessages.h:546:75: error: unknown type name 'MediaTime'
    typedef std::tuple<const WebKit::TrackPrivateRemoteIdentifier&, const MediaTime&, const MediaTime&, const IPC::DataReference&> Arguments;
Comment 1 Don Olmstead 2020-03-11 17:20:38 PDT 
Created attachment 393313 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-11 18:35:31 PDT 
Comment on attachment 393313 [details]
Patch

Clearing flags on attachment: 393313

Committed r258305: <https://trac.webkit.org/changeset/258305>
Comment 3 WebKit Commit Bot 2020-03-11 18:35:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-11 18:36:17 PDT 
<rdar://problem/60351441>