import Flatpack was added to run-webkit-test as a required import and means that we can't run the script without it on any other platforms, even when not needed. We should be able to run the script and determine at call time if we need the import.
<rdar://problem/60346729>
Created attachment 393308 [details] Patch
Comment on attachment 393308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review This looks correct to be, but I'd like the folks more familiar with how we actually use flatpak. Another alternative approach would be to conditionalize on if flatpak can be found in the provided directory. > Tools/Scripts/run-webkit-tests:16 > +# * Neither the Google name nor the names of its No reason to make this change
Comment on attachment 393308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review > Tools/Scripts/run-webkit-tests:39 > +if sys.platform.startswith('Linux'): lower-case linux
Created attachment 393386 [details] Patch
Comment on attachment 393386 [details] Patch Clearing flags on attachment: 393386 Committed r258347: <https://trac.webkit.org/changeset/258347>
All reviewed patches have been landed. Closing bug.