This function should only be called on iOS, not on macOS.
Created attachment 393302 [details] Patch
Comment on attachment 393302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393302&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:459 > + if (_AXSApplicationAccessibilityEnabled()) So we still want to pass the cfprefsd extension on macOS without checking this call? > Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:213 > +#if PLATFORM(IOS_FAMILY) Does this call work on MacCatalyst? Maybe this should exclude MacCatalyst builds?
r=me, but please make sure the MacCatalyst bits are correct.
Committed r258294: <https://trac.webkit.org/changeset/258294/webkit>
<rdar://problem/60346791>
(In reply to Brent Fulgham from comment #2) > Comment on attachment 393302 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393302&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:459 > > + if (_AXSApplicationAccessibilityEnabled()) > > So we still want to pass the cfprefsd extension on macOS without checking > this call? > I believe we want a similar functionality on macOS, but we cannot use _AXSApplicationAccessibilityEnabled() for this. I am looking into alternatives. > > Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:213 > > +#if PLATFORM(IOS_FAMILY) > > Does this call work on MacCatalyst? Maybe this should exclude MacCatalyst > builds? Yes, I believe this will work on MacCatalyst. Thanks for reviewing!
Re-opened since this is blocked by bug 208957
Created attachment 393397 [details] Patch
Created attachment 393400 [details] Patch
Comment on attachment 393400 [details] Patch Hopefully this will get the bots happy. r=me
Comment on attachment 393400 [details] Patch Thanks for reviewing!
Comment on attachment 393400 [details] Patch Clearing flags on attachment: 393400 Committed r258359: <https://trac.webkit.org/changeset/258359>
All reviewed patches have been landed. Closing bug.