Bug 208949 - Add a parameter to allow ignoring app-bound domain categorization
Summary: Add a parameter to allow ignoring app-bound domain categorization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks: 209842
  Show dependency tree / graph
 
Reported: 2020-03-11 15:19 PDT by Kate Cheney
Modified: 2020-03-31 18:02 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2020-03-11 15:25 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch for landing (5.88 KB, patch)
2020-03-11 15:51 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch for landing (5.88 KB, patch)
2020-03-11 16:05 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2020-03-11 15:19:55 PDT 
In some cases we would like a way to avoid setting parameters based on app-bound domain navigation. We should have a way to do this.
Comment 1 Kate Cheney 2020-03-11 15:20:13 PDT 
<rdar://problem/60239187>
Comment 2 Kate Cheney 2020-03-11 15:25:23 PDT 
Created attachment 393294 [details]
Patch
Comment 3 Brent Fulgham 2020-03-11 15:27:44 PDT 
Comment on attachment 393294 [details]
Patch

r=me
Comment 4 Chris Dumez 2020-03-11 15:36:54 PDT 
Comment on attachment 393294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393294&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:1218
> +- (void)_setIgnoreAppBoundDomains:(BOOL)shouldIgnoreAppBoundDomains

I don't this the naming is right here. I think it should either:
_ignoresAppBoundDomains / _setIgnoresAppBoundDomains
or
_shouldIgnoreAppBoundDomains / _setShouldIgnoreAppBoundDomains
Comment 5 Kate Cheney 2020-03-11 15:51:15 PDT 
Created attachment 393297 [details]
Patch for landing
Comment 6 Kate Cheney 2020-03-11 15:51:54 PDT 
(In reply to katherine_cheney from comment #5)
> Created attachment 393297 [details]
> Patch for landing

missed one.
Comment 7 Kate Cheney 2020-03-11 16:05:20 PDT 
Created attachment 393300 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2020-03-11 16:54:04 PDT 
Comment on attachment 393300 [details]
Patch for landing

Clearing flags on attachment: 393300

Committed r258296: <https://trac.webkit.org/changeset/258296>
Comment 9 WebKit Commit Bot 2020-03-11 16:54:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-03-11 16:55:14 PDT 
<rdar://problem/60348017>