Bug 208940 – Add API endpoint in EWS django app to provide patch status in json format

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Add API endpoint in EWS django app to provide patch status in json format. This data can be used by other tools.

[Aakash Jain]

Created attachment 393279 [details]
Patch

[Aakash Jain]

e.g.: https://ews.webkit-uat.org/status/390184/

[Jonathan Bedard]

Comment on attachment 393279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393279&action=review

> Tools/ChangeLog:3
> +        Add API endpoint in EWS django app to provide patch status in json format

Good idea, curious if there is a specific use case you had in mind for this

> Tools/BuildSlaveSupport/ews-app/ews/views/status.py:43
> +        if build.result is None:

I wonder if something like this would be more elegant:

bubble['state'] = {
    None: 'started',
    Buildbot.SUCCESS: 'pass',
    Buildbot.WARNINGS: 'pass',
    ...
}.get(build.result, 'error')

[Aakash Jain]

Created attachment 393419 [details]
Patch

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> Good idea, curious if there is a specific use case you had in mind for this
For https://bugs.webkit.org/show_bug.cgi?id=208938

> I wonder if something like this would be more elegant:
I simplified it further, simply used build.result for 'state'.

[Jonathan Bedard]

Comment on attachment 393419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393419&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/status.py:67
> +        response_data = {'status': self._build_statuses_for_patch(patch)}

I think we should return the list directly instead of packaging it in a dictionary.

[Aakash Jain]

Created attachment 393511 [details]
Patch for landing

[Aakash Jain]

(In reply to Jonathan Bedard from comment #6)
> I think we should return the list directly instead of packaging it in a dictionary.
Done in updated patch.

[WebKit Commit Bot]

Comment on attachment 393511 [details]
Patch for landing

Clearing flags on attachment: 393511

Committed r258415: <https://trac.webkit.org/changeset/258415>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60427130>