Bug 208930 – REGRESSION: (r257915?) [ Mac ] accessibility/accessibility-node-memory-management.html is flaky failing.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Jason Lawrence]

accessibility/accessibility-node-memory-management.html

Description:
This test is flaky failing on Mac. Most of the failure are on Debug, and they look pretty consistent. There appears to be a regression point at r257915.

History:
https://results.webkit.org/?suite=layout-tests&test=accessibility%2Faccessibility-node-memory-management.html&platform=ios&platform=mac&flavor=wk2&flavor=wk1&style=release&style=debug&limit=50000

Diff:
--- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/accessibility/accessibility-node-memory-management-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/accessibility/accessibility-node-memory-management-actual.txt
@@ -5,7 +5,7 @@
 
 PASS expectedButtonRole != expectedDetachedRole is true
 PASS canvasButtonRole is expectedButtonRole
-PASS detachedCanvasButtonRole is expectedDetachedRole
+FAIL detachedCanvasButtonRole should be AXRole: . Was AXRole: AXButton.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Radar WebKit Bug Importer]

<rdar://problem/60330667>

[Jason Lawrence]

I have marked this test as failing here: https://trac.webkit.org/changeset/258270/webkit

Issue will be tracked in this Radar:
<rdar://problem/60173203>

[Andres Gonzalez]

Created attachment 404164 [details]
Patch

[chris fleizach]

Comment on attachment 404164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404164&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:293
> +    bool updatedChild = false; // Set to true if at least one child's subtree  is updated.

extra space after subtree

[Andres Gonzalez]

Created attachment 404167 [details]
Patch

[EWS]

Committed r264323: <https://trac.webkit.org/changeset/264323>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404167 [details].