Bug 208927 – Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page:
   1 com.apple.JavaScriptCore       0x00001dbe WTFCrash + 0 (Assertions.cpp:305)
   2 com.apple.WebKit               0x00002dab WTFCrashWithInfo(int, char const*, char const*, int) + 0
>  3 com.apple.WebKit               0x00ad845d WebKit::WebPageProxy::suspendCurrentPageIfPossible(API::Navigation&, WTF::Optional<WTF::ObjectIdentifier<WebCore::FrameIdentifierType> >, WebKit::ProcessSwapRequestedByClient, WebKit::ShouldDelayClosingUntilEnteringAcceleratedCompositingMode) + 0 (WebPageProxy.cpp:782)
   4 com.apple.WebKit               0x00aeb211 WebKit::WebPageProxy::commitProvisionalPage(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&) + 0 (WebPageProxy.cpp:2993)
   5 com.apple.WebKit               0x00978770 WebKit::ProvisionalPageProxy::didCommitLoadForFrame(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&) + 0
   6 com.apple.WebKit               0x009b5310 void IPC::callMemberFunctionImpl<WebKit::ProvisionalPageProxy, void (WebKit::ProvisionalPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>(WebKit::ProvisionalPageProxy*, void (WebKit::ProvisionalPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>) + 0 (HandleMessage.h:42)
   7 com.apple.WebKit               0x009add10 void IPC::callMemberFunction<WebKit::ProvisionalPageProxy, void (WebKit::ProvisionalPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul> >(std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>&&, WebKit::ProvisionalPageProxy*, void (WebKit::ProvisionalPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&)) + 0 (HandleMessage.h:48)
   8 com.apple.WebKit               0x0097b57c void IPC::handleMessage<Messages::WebPageProxy::DidCommitLoadForFrame, WebKit::ProvisionalPageProxy, void (WebKit::ProvisionalPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&)>(IPC::Decoder&, WebKit::ProvisionalPageProxy*, void (WebKit::ProvisionalPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&)) + 0 (HandleMessage.h:121)
   9 com.apple.WebKit               0x0097a177 WebKit::ProvisionalPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 0 (ProvisionalPageProxy.cpp:454)
  10 com.apple.WebKit               0x000e9f89 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 0 (MessageReceiverMap.cpp:124)
  11 com.apple.WebKit               0x00925a14 WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 0 (AuxiliaryProcessProxy.cpp:191)
  12 com.apple.WebKit               0x00bf88ca WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 0 (WebProcessProxy.cpp:660)
  13 com.apple.WebKit               0x00073559 IPC::Connection::dispatchMessage(IPC::Decoder&) + 0 (Connection.cpp:950)
  14 com.apple.WebKit               0x0006ca8b IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 0
  15 com.apple.WebKit               0x0007250b IPC::Connection::dispatchIncomingMessages() + 0 (Connection.cpp:1105)
  16 com.apple.WebKit               0x0008f8b6 IPC::Connection::MessagesThrottler::scheduleMessagesDispatch()::$_9::operator()() + 0 (Connection.cpp:1038)
  17 com.apple.WebKit               0x0008f7a9 WTF::Detail::CallableWrapper<IPC::Connection::MessagesThrottler::scheduleMessagesDispatch()::$_9, void>::call() + 0 (Function.h:52)

[Chris Dumez]

<rdar://problem/55448331>

[Chris Dumez]

Created attachment 393261 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 393261 [details]
Patch

Clearing flags on attachment: 393261

Committed r258272: <https://trac.webkit.org/changeset/258272>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.