Bug 208897 - Non-unified build fixes early March 2020 edition
Summary: Non-unified build fixes early March 2020 edition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-10 17:02 PDT by Don Olmstead
Modified: 2020-03-15 11:59 PDT (History)
20 users (show)

See Also:


Attachments
Patch (4.54 KB, patch)
2020-03-10 17:28 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-03-10 17:02:51 PDT
Letting the days go by (same as it ever was)
Same as it ever was (same as it ever was)
Letting the days go by (same as it ever was)
Same as it ever was
Comment 1 Don Olmstead 2020-03-10 17:28:54 PDT
Created attachment 393188 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-10 19:41:04 PDT
Comment on attachment 393188 [details]
Patch

Clearing flags on attachment: 393188

Committed r258248: <https://trac.webkit.org/changeset/258248>
Comment 3 WebKit Commit Bot 2020-03-10 19:41:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-10 19:42:19 PDT
<rdar://problem/60304002>
Comment 5 Darin Adler 2020-03-15 11:59:42 PDT
Comment on attachment 393188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393188&action=review

> Source/WebCore/dom/BoundaryPoint.h:28
> +#include "Node.h"

it’s a pretty big change to BoundaryPoint.h, causing to pull in all of Node.h. It obviates the need for BoundaryPoint.cpp entirely since that was the only thing different driving us to not have all functions be inlines.

How did you determine this was needed, and couldn’t be fixed by adding includes elsewhere?