Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters
Created attachment 393187 [details] Patch
Comment on attachment 393187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393187&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1176 > + setResourceLoadStatisticsEnabled(parameters.resourceLoadStatisticsParameters.enableResourceLoadStatistics); Since this is a NetworkSessionCreationParameters&&, we could move some of these values, like m_resourceLoadStatisticsDirectory > Source/WebKit/Shared/ResourceLoadStatisticsParameters.h:36 > +struct ResourceLoadStatisticsParameters { Given we have ResourceLoadStatistics inside ResourceLoadStatisticsParameters, could we remove ResourceLoadStatistics from the parameter names. For instance s/resourceLoadStatisticsDirectory/directoy and s/resourceLoadStatisticsDirectoryExtensionHandle/directoryExtensionHandle.
Created attachment 393255 [details] Patch
It looks good to me too.
The commit-queue encountered the following flaky tests while processing attachment 393255 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch.
Comment on attachment 393255 [details] Patch Clearing flags on attachment: 393255 Committed r258269: <https://trac.webkit.org/changeset/258269>
All reviewed patches have been landed. Closing bug.
<rdar://problem/60330048>
I think this patch is breaking Apple's internal builds.
I believe I fixed that.