Bug 208895 – Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters

[Alex Christensen]

Created attachment 393187 [details]
Patch

[youenn fablet]

Comment on attachment 393187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393187&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1176
> +    setResourceLoadStatisticsEnabled(parameters.resourceLoadStatisticsParameters.enableResourceLoadStatistics);

Since this is a NetworkSessionCreationParameters&&, we could move some of these values, like m_resourceLoadStatisticsDirectory

> Source/WebKit/Shared/ResourceLoadStatisticsParameters.h:36
> +struct ResourceLoadStatisticsParameters {

Given we have ResourceLoadStatistics inside ResourceLoadStatisticsParameters, could we remove ResourceLoadStatistics from the parameter names.
For instance s/resourceLoadStatisticsDirectory/directoy and s/resourceLoadStatisticsDirectoryExtensionHandle/directoryExtensionHandle.

[Alex Christensen]

Created attachment 393255 [details]
Patch

[John Wilander]

It looks good to me too.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 393255 [details]:

imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 393255 [details]
Patch

Clearing flags on attachment: 393255

Committed r258269: <https://trac.webkit.org/changeset/258269>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60330048>

[Myles C. Maxfield]

I think this patch is breaking Apple's internal builds.

[Alex Christensen]

I believe I fixed that.