Bug 208895 - Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters
Summary: Introduce ResourceLoadStatisticsParameters and move members from NetworkSessi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-10 16:56 PDT by Alex Christensen
Modified: 2020-03-11 12:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (33.16 KB, patch)
2020-03-10 16:58 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (31.91 KB, patch)
2020-03-11 09:44 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-03-10 16:56:42 PDT 
Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters
Comment 1 Alex Christensen 2020-03-10 16:58:17 PDT 
Created attachment 393187 [details]
Patch
Comment 2 youenn fablet 2020-03-11 06:54:35 PDT 
Comment on attachment 393187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393187&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1176
> +    setResourceLoadStatisticsEnabled(parameters.resourceLoadStatisticsParameters.enableResourceLoadStatistics);

Since this is a NetworkSessionCreationParameters&&, we could move some of these values, like m_resourceLoadStatisticsDirectory

> Source/WebKit/Shared/ResourceLoadStatisticsParameters.h:36
> +struct ResourceLoadStatisticsParameters {

Given we have ResourceLoadStatistics inside ResourceLoadStatisticsParameters, could we remove ResourceLoadStatistics from the parameter names.
For instance s/resourceLoadStatisticsDirectory/directoy and s/resourceLoadStatisticsDirectoryExtensionHandle/directoryExtensionHandle.
Comment 3 Alex Christensen 2020-03-11 09:44:12 PDT 
Created attachment 393255 [details]
Patch
Comment 4 John Wilander 2020-03-11 10:04:51 PDT 
It looks good to me too.
Comment 5 WebKit Commit Bot 2020-03-11 10:42:03 PDT 
The commit-queue encountered the following flaky tests while processing attachment 393255 [details]:

imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-03-11 10:42:43 PDT 
Comment on attachment 393255 [details]
Patch

Clearing flags on attachment: 393255

Committed r258269: <https://trac.webkit.org/changeset/258269>
Comment 7 WebKit Commit Bot 2020-03-11 10:42:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-11 10:43:13 PDT 
<rdar://problem/60330048>
Comment 9 Myles C. Maxfield 2020-03-11 12:45:28 PDT 
I think this patch is breaking Apple's internal builds.
Comment 10 Alex Christensen 2020-03-11 12:50:01 PDT 
I believe I fixed that.