Bug 208882 - [PlayStation] incomplete type 'WebCore::ScrollingStateFrameScrollingNode' named in nested name specifier
Summary: [PlayStation] incomplete type 'WebCore::ScrollingStateFrameScrollingNode' nam...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2020-03-10 14:20 PDT by Stephan Szabo
Modified: 2020-03-10 16:37 PDT (History)
12 users (show)

See Also:

Patch (1.33 KB, patch)
2020-03-10 14:23 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2020-03-10 14:20:29 PDT
We started seeing errors in the ENABLE(SCROLLING_THREAD) block with:

../../Source/WebCore\page/scrolling/ScrollingTreeScrollingNode.cpp:98:34: error: incomplete type 'WebCore::ScrollingStateFrameScrollingNode' named in nested name specifier
    if (state.hasChangedProperty(ScrollingStateFrameScrollingNode::ReasonsForSynchronousScrolling))
Comment 1 Stephan Szabo 2020-03-10 14:23:37 PDT
Created attachment 393178 [details]

Adding include for ScrollingStateFrameScrollingNode, checking if this is okay on the various EWS bots.
Comment 2 Ross Kirsling 2020-03-10 15:17:51 PDT
Comment on attachment 393178 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=393178&action=review

Seems like more than a PS port fix, this is a missing include from r258012?

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:34
> +#include "ScrollingStateFrameScrollingNode.h"
> +#endif

Judging from other CPP files that include this, I think you can probably get away without guarding the include.
Comment 3 Stephan Szabo 2020-03-10 15:26:18 PDT
I'm not sure if anyone else is hitting the code in question with the combination of enable flags, but noticed it from the PlayStation buildbot.

I'd figured I'd guard the include to prevent bringing in the full include for cases that were okay with just the forward declaration, but can do it unconditionally.
Comment 4 WebKit Commit Bot 2020-03-10 16:36:43 PDT
Comment on attachment 393178 [details]

Clearing flags on attachment: 393178

Committed r258238: <https://trac.webkit.org/changeset/258238>
Comment 5 WebKit Commit Bot 2020-03-10 16:36:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-10 16:37:16 PDT