RenderBlock suppresses repainting during layout if m_everHadLayout is false. As the FIXME in RenderObject::checkForRepaintDuringLayout() says, this should be generalized to all RenderObjects.
Created attachment 156001 [details] wip, I expect the cr-ews will see some pixel failures
Comment on attachment 156001 [details] wip, I expect the cr-ews will see some pixel failures Attachment 156001 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13424131 New failing tests: svg/hixie/perf/004.xml svg/hixie/perf/005.xml svg/custom/js-late-marker-creation.svg svg/carto.net/window.svg svg/custom/use-detach.svg svg/custom/js-late-clipPath-and-object-creation.svg svg/custom/js-late-mask-creation.svg svg/hixie/perf/006.xml svg/custom/js-late-mask-and-object-creation.svg svg/custom/js-late-clipPath-creation.svg
Created attachment 156007 [details] Archive of layout-test-results from gce-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Very interesting. I'll look into the failures more in the morning, but these look identical to failures seen in bug 92800. I believe SVG just isn't ready for this optimization as I think this optimization depends on parents telling their children to do a full repaint when they do their first layout, but I'm not yet sure.
Created attachment 156786 [details] Should fix SVG, but may have other bugs
Comment on attachment 156786 [details] Should fix SVG, but may have other bugs Attachment 156786 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13452100 New failing tests: svg/custom/use-detach.svg
Created attachment 156841 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Perfect! That one appears to be a progression. I'll upload a patch for real review shortly.
Created attachment 156880 [details] Patch
Comment on attachment 156880 [details] Patch Attachment 156880 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13452225 New failing tests: svg/custom/use-detach.svg
Created attachment 156905 [details] Archive of layout-test-results from gce-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 156976 [details] Patch including more updated pixel results
Any thoughts?
Comment on attachment 156976 [details] Patch including more updated pixel results Thanks mitz!
Comment on attachment 156976 [details] Patch including more updated pixel results Clearing flags on attachment: 156976 Committed r125160: <http://trac.webkit.org/changeset/125160>
All reviewed patches have been landed. Closing bug.