Bug 208834 - [macOS] Notification observer is not removed
Summary: [macOS] Notification observer is not removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-09 15:01 PDT by Per Arne Vollan
Modified: 2020-03-17 16:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.71 KB, patch)
2020-03-09 15:09 PDT, Per Arne Vollan 		thorton: review+
Details | Formatted Diff | Diff
Patch (8.71 KB, patch)
2020-03-09 15:25 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-03-09 15:01:13 PDT 
The Accessibility notification observer is not being removed on macOS.
Comment 1 Per Arne Vollan 2020-03-09 15:01:38 PDT 
rdar://problem/60238852
Comment 2 Per Arne Vollan 2020-03-09 15:09:31 PDT 
Created attachment 393079 [details]
Patch
Comment 3 Per Arne Vollan 2020-03-09 15:25:19 PDT 
Created attachment 393084 [details]
Patch
Comment 4 Per Arne Vollan 2020-03-09 15:25:46 PDT 
Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-03-09 16:48:58 PDT 
Committed r258174: <https://trac.webkit.org/changeset/258174/webkit>
Comment 6 Darin Adler 2020-03-17 15:52:32 PDT 
Comment on attachment 393079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393079&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:693
>  #endif
>  #endif // PLATFORM(IOS)
>  #endif // !PLATFORM(IOS_FAMILY)

I think we’d do better at understanding the conditionals here if this wasn’t nested.
Comment 7 Per Arne Vollan 2020-03-17 16:05:46 PDT 
(In reply to Darin Adler from comment #6)
> Comment on attachment 393079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393079&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:693
> >  #endif
> >  #endif // PLATFORM(IOS)
> >  #endif // !PLATFORM(IOS_FAMILY)
> 
> I think we’d do better at understanding the conditionals here if this wasn’t
> nested.

That's a good point, it can be a bit confusing.

Thanks for reviewing!