Bug 208830 – Remove obsolete feature flags

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Don Olmstead]

Remove any obsolete ENABLE flags from the build system. Find any misused ENABLE flags.

[Don Olmstead]

Created attachment 393069 [details]
WIP Patch

[Don Olmstead]

Created attachment 393076 [details]
WIP Patch

[Jonathan Bedard]

(In reply to Don Olmstead from comment #0)
> Remove any obsolete ENABLE flags from the build system. Find any misused
> ENABLE flags.

Could we make the bug title a bit more descriptive? Something like 'Remove obsolete feature flags'. Cleanup feature defines could refer to a few different things.

[Don Olmstead]

Created attachment 393082 [details]
Patch

[Don Olmstead]

Created attachment 393095 [details]
Patch

Don't try and sort anything in FeatureDefines.xcconfig.

[Alex Christensen]

Comment on attachment 393095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393095&action=review

> Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:-314
> -ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));

This is very much still used

[Don Olmstead]

(In reply to Alex Christensen from comment #6)
> Comment on attachment 393095 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393095&action=review
> 
> > Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:-314
> > -ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME));
> 
> This is very much still used

https://trac.webkit.org/changeset/258148/webkit

[Don Olmstead]

Created attachment 393099 [details]
Patch

Reuploading to make sure the changelog is clear about ENABLE_POINTER_EVENTS being removed in a patch today.

[WebKit Commit Bot]

Comment on attachment 393099 [details]
Patch

Clearing flags on attachment: 393099

Committed r258181: <https://trac.webkit.org/changeset/258181>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60255677>

[Darin Adler]

Comment on attachment 393099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393099&action=review

> Source/cmake/WebKitFeatures.cmake:228
> +    WEBKIT_OPTION_DEFINE(ENABLE_WIRELESS_PLAYBACK_TARGET "Togle wireless playback target support" PRIVATE OFF)

"Togle"!

[Darin Adler]

Comment on attachment 393099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393099&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:424
> -#if ENABLE(WIRELESS_TARGET_PLAYBACK)
> +#if ENABLE(WIRELESS_PLAYBACK_TARGET)
>      configuration->_allowsAirPlayForMediaPlayback = self->_allowsAirPlayForMediaPlayback;
>  #endif

Love that you fixed this. Puzzled that there is no test coverage!

[Don Olmstead]

(In reply to Darin Adler from comment #13)
> Comment on attachment 393099 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393099&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:424
> > -#if ENABLE(WIRELESS_TARGET_PLAYBACK)
> > +#if ENABLE(WIRELESS_PLAYBACK_TARGET)
> >      configuration->_allowsAirPlayForMediaPlayback = self->_allowsAirPlayForMediaPlayback;
> >  #endif
> 
> Love that you fixed this. Puzzled that there is no test coverage!

Yea there were a few I was surprised to find.

Thank the script at https://bugs.webkit.org/show_bug.cgi?id=208726 which found these issues. Hoping to get it integrated tomorrow and also start generating some of these things.