Bug 208823 - WebKitTestRunner bundleID should not be cleared before every test
Summary: WebKitTestRunner bundleID should not be cleared before every test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-09 10:57 PDT by Kate Cheney
Modified: 2020-03-09 17:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2020-03-09 11:14 PDT, Kate Cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2020-03-09 10:57:15 PDT
This is causing test failures for layout tests which rely on the Info.plist bundle identifier (not the one set via the override method)
Comment 1 Kate Cheney 2020-03-09 10:57:43 PDT
<rdar://problem/60204539>
Comment 2 Kate Cheney 2020-03-09 11:14:09 PDT
Created attachment 393056 [details]
Patch
Comment 3 Per Arne Vollan 2020-03-09 14:20:38 PDT
Comment on attachment 393056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review

> Tools/WebKitTestRunner/TestController.cpp:643
> +        clearApplicationBundleIdentifierTestingOverride();

What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist?
Comment 4 Kate Cheney 2020-03-09 14:23:55 PDT
(In reply to Per Arne Vollan from comment #3)
> Comment on attachment 393056 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393056&action=review
> 
> > Tools/WebKitTestRunner/TestController.cpp:643
> > +        clearApplicationBundleIdentifierTestingOverride();
> 
> What happens with the next test if this is executed? Will it use the new
> bundle id, or fall back to the one from Info.plist?

Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions.
Comment 5 Per Arne Vollan 2020-03-09 14:27:08 PDT
Comment on attachment 393056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review

R=me.

>>> Tools/WebKitTestRunner/TestController.cpp:643
>>> +        clearApplicationBundleIdentifierTestingOverride();
>> 
>> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist?
> 
> Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions.

Sounds good!
Comment 6 Kate Cheney 2020-03-09 16:14:47 PDT
(In reply to Per Arne Vollan from comment #5)
> Comment on attachment 393056 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393056&action=review
> 
> R=me.
> 
> >>> Tools/WebKitTestRunner/TestController.cpp:643
> >>> +        clearApplicationBundleIdentifierTestingOverride();
> >> 
> >> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist?
> > 
> > Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions.
> 
> Sounds good!

Thanks for the review!
Comment 7 WebKit Commit Bot 2020-03-09 16:59:45 PDT
Comment on attachment 393056 [details]
Patch

Clearing flags on attachment: 393056

Committed r258178: <https://trac.webkit.org/changeset/258178>
Comment 8 WebKit Commit Bot 2020-03-09 16:59:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-03-09 17:00:31 PDT
<rdar://problem/60250510>