Bug 208823 – WebKitTestRunner bundleID should not be cleared before every test

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

This is causing test failures for layout tests which rely on the Info.plist bundle identifier (not the one set via the override method)

[Kate Cheney]

<rdar://problem/60204539>

[Kate Cheney]

Created attachment 393056 [details]
Patch

[Per Arne Vollan]

Comment on attachment 393056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review

> Tools/WebKitTestRunner/TestController.cpp:643
> +        clearApplicationBundleIdentifierTestingOverride();

What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist?

[Kate Cheney]

(In reply to Per Arne Vollan from comment #3)
> Comment on attachment 393056 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393056&action=review
> 
> > Tools/WebKitTestRunner/TestController.cpp:643
> > +        clearApplicationBundleIdentifierTestingOverride();
> 
> What happens with the next test if this is executed? Will it use the new
> bundle id, or fall back to the one from Info.plist?

Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions.

[Per Arne Vollan]

Comment on attachment 393056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review

R=me.

>>> Tools/WebKitTestRunner/TestController.cpp:643
>>> +        clearApplicationBundleIdentifierTestingOverride();
>> 
>> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist?
> 
> Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions.

Sounds good!

[Kate Cheney]

(In reply to Per Arne Vollan from comment #5)
> Comment on attachment 393056 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393056&action=review
> 
> R=me.
> 
> >>> Tools/WebKitTestRunner/TestController.cpp:643
> >>> +        clearApplicationBundleIdentifierTestingOverride();
> >> 
> >> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist?
> > 
> > Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions.
> 
> Sounds good!

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 393056 [details]
Patch

Clearing flags on attachment: 393056

Committed r258178: <https://trac.webkit.org/changeset/258178>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60250510>