Bug 208816 – Remove sync IPC when creating a remote capture source

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Remove sync IPC when creating a remote capture source

[youenn fablet]

Created attachment 393040 [details]
Patch

[youenn fablet]

Created attachment 393041 [details]
Patch

[youenn fablet]

Created attachment 393042 [details]
Patch

[youenn fablet]

Created attachment 393043 [details]
Patch

[Eric Carlson]

Comment on attachment 393043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393043&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98
> +    CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable {

Shouldn't this be called 'waitForVideoSource'?

Why do you WTFMove() videoSource but not audioSource?

[youenn fablet]

(In reply to Eric Carlson from comment #5)
> Comment on attachment 393043 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393043&action=review
> 
> > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98
> > +    CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable {
> 
> Shouldn't this be called 'waitForVideoSource'?

I will rename it to onceAudioSourceReady.

> Why do you WTFMove() videoSource but not audioSource?

We are using audioSource below so cannot do that.

[youenn fablet]

Created attachment 393136 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 393136 [details]
Patch for landing

Clearing flags on attachment: 393136

Committed r258201: <https://trac.webkit.org/changeset/258201>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60270112>