Bug 208816 - Remove sync IPC when creating a remote capture source
Summary: Remove sync IPC when creating a remote capture source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-09 08:53 PDT by youenn fablet
Modified: 2020-03-10 05:54 PDT (History)
11 users (show)

See Also:


Attachments
Patch (23.35 KB, patch)
2020-03-09 09:03 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (23.35 KB, patch)
2020-03-09 09:04 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (23.37 KB, patch)
2020-03-09 09:07 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (23.64 KB, patch)
2020-03-09 09:12 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (23.74 KB, patch)
2020-03-10 05:04 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-09 08:53:20 PDT
Remove sync IPC when creating a remote capture source
Comment 1 youenn fablet 2020-03-09 09:03:37 PDT
Created attachment 393040 [details]
Patch
Comment 2 youenn fablet 2020-03-09 09:04:32 PDT
Created attachment 393041 [details]
Patch
Comment 3 youenn fablet 2020-03-09 09:07:22 PDT
Created attachment 393042 [details]
Patch
Comment 4 youenn fablet 2020-03-09 09:12:12 PDT
Created attachment 393043 [details]
Patch
Comment 5 Eric Carlson 2020-03-09 11:11:15 PDT
Comment on attachment 393043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393043&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98
> +    CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable {

Shouldn't this be called 'waitForVideoSource'?

Why do you WTFMove() videoSource but not audioSource?
Comment 6 youenn fablet 2020-03-10 04:45:46 PDT
(In reply to Eric Carlson from comment #5)
> Comment on attachment 393043 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393043&action=review
> 
> > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98
> > +    CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable {
> 
> Shouldn't this be called 'waitForVideoSource'?

I will rename it to onceAudioSourceReady.

> Why do you WTFMove() videoSource but not audioSource?

We are using audioSource below so cannot do that.
Comment 7 youenn fablet 2020-03-10 05:04:53 PDT
Created attachment 393136 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2020-03-10 05:53:45 PDT
Comment on attachment 393136 [details]
Patch for landing

Clearing flags on attachment: 393136

Committed r258201: <https://trac.webkit.org/changeset/258201>
Comment 9 WebKit Commit Bot 2020-03-10 05:53:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-03-10 05:54:17 PDT
<rdar://problem/60270112>