Remove sync IPC when creating a remote capture source
Created attachment 393040 [details] Patch
Created attachment 393041 [details] Patch
Created attachment 393042 [details] Patch
Created attachment 393043 [details] Patch
Comment on attachment 393043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393043&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98 > + CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable { Shouldn't this be called 'waitForVideoSource'? Why do you WTFMove() videoSource but not audioSource?
(In reply to Eric Carlson from comment #5) > Comment on attachment 393043 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393043&action=review > > > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98 > > + CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable { > > Shouldn't this be called 'waitForVideoSource'? I will rename it to onceAudioSourceReady. > Why do you WTFMove() videoSource but not audioSource? We are using audioSource below so cannot do that.
Created attachment 393136 [details] Patch for landing
Comment on attachment 393136 [details] Patch for landing Clearing flags on attachment: 393136 Committed r258201: <https://trac.webkit.org/changeset/258201>
All reviewed patches have been landed. Closing bug.
<rdar://problem/60270112>