Bug 208812 - Creating paths that are single-segment bezier or quad curves should not require a CGPath allocation
Summary: Creating paths that are single-segment bezier or quad curves should not requi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2020-03-09 08:09 PDT by Wenson Hsieh
Modified: 2020-03-09 13:57 PDT (History)
7 users (show)

See Also:

Patch (14.44 KB, patch)
2020-03-09 08:41 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-03-09 08:09:49 PDT
Fold simple bezier and quad curves into inline path data as well.
Comment 1 Wenson Hsieh 2020-03-09 08:41:16 PDT
Created attachment 393037 [details]
Comment 2 WebKit Commit Bot 2020-03-09 12:55:59 PDT
Comment on attachment 393037 [details]

Clearing flags on attachment: 393037

Committed r258151: <https://trac.webkit.org/changeset/258151>
Comment 3 WebKit Commit Bot 2020-03-09 12:56:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-09 12:56:21 PDT
Comment 5 Darin Adler 2020-03-09 13:57:52 PDT
Comment on attachment 393037 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=393037&action=review

> Source/WebCore/platform/graphics/Path.cpp:273
> +    if (hasInlineData<LineData>() || hasInlineData<BezierCurveData>() || hasInlineData<QuadCurveData>())

Eventually we will get to the point where a single switchOn is more efficient than these multiple calls.