Bug 208811 - Generate commit-queue status bubble from new EWS
Summary: Generate commit-queue status bubble from new EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 201934
  Show dependency tree / graph
 
Reported: 2020-03-09 07:48 PDT by Aakash Jain
Modified: 2020-03-18 07:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2020-03-09 07:49 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-09 07:48:14 PDT 
Display commit-queue status bubble from new EWS.
Comment 1 Aakash Jain 2020-03-09 07:49:56 PDT 
Created attachment 393033 [details]
Patch
Comment 3 Jonathan Bedard 2020-03-09 09:33:49 PDT 
Comment on attachment 393033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302
> +            for queue in StatusBubble.ALL_QUEUES:

This part confuses me a bit because it seems to be the inverse of what we had before.

Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot.
Comment 4 Aakash Jain 2020-03-09 09:41:58 PDT 
Comment on attachment 393033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302
>> +            for queue in StatusBubble.ALL_QUEUES:
> 
> This part confuses me a bit because it seems to be the inverse of what we had before.
> 
> Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot.

Before, if a patch was not sent to buildbot, we would exit early and display submit-to-ews button. If the patch was sent to buildbot, we would generate all it's bubbles. Should be same now as well.
Comment 5 Jonathan Bedard 2020-03-09 11:48:21 PDT 
Comment on attachment 393033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review

>>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302
>>> +            for queue in StatusBubble.ALL_QUEUES:
>> 
>> This part confuses me a bit because it seems to be the inverse of what we had before.
>> 
>> Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot.
> 
> Before, if a patch was not sent to buildbot, we would exit early and display submit-to-ews button. If the patch was sent to buildbot, we would generate all it's bubbles. Should be same now as well.

I'm sorry, you're right, was mis-reading the code.
Comment 6 EWS 2020-03-10 05:27:25 PDT 
Committed r258198: <https://trac.webkit.org/changeset/258198>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393033 [details].
Comment 7 Radar WebKit Bug Importer 2020-03-10 05:28:12 PDT 
<rdar://problem/60269688>